Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Firing a simple event named e" #1887

Closed
annevk opened this issue Oct 11, 2016 · 5 comments
Closed

Remove "Firing a simple event named e" #1887

annevk opened this issue Oct 11, 2016 · 5 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: events

Comments

@annevk
Copy link
Member

annevk commented Oct 11, 2016

This algorithm basically duplicates "concept-event-fire".

To fix this:

  1. Remove the paragraph that introduces this algorithm.
  2. Replace any references to this algorithm with something like <span data-x="concept-event-fire">fire an event</span> (depends on context).
@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project clarification Standard could be clearer labels Oct 11, 2016
@domenic
Copy link
Member

domenic commented Oct 11, 2016

Related: #1713

@sendilkumarn
Copy link
Contributor

Is this up for grab? I would like to give it a shot.

@annevk
Copy link
Member Author

annevk commented Oct 17, 2016

@sendilkumarn that sounds great, but it's probably best to wait until #1886 lands as that will address some of the work and will change a few things around. I will make sure to ping this issue once that is done.

@sendilkumarn
Copy link
Contributor

Thanks I will keep an eye too.

@domenic domenic mentioned this issue Oct 17, 2016
Merged
domenic pushed a commit that referenced this issue Oct 18, 2016
@annevk @domenic
Editorial: major cleanup around firing and dispatching events
8ffbd14 
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes #1713, but plenty of follow up issues remain:

* #805 for the remainder of "default action" usage
* #1394 for updating synthetic click events
* #1887 for removing "fire a simple event" usage
* #1893 for updating when checkboxes get checked
* #1900 for figuring out if event dispatch requires more hooks
* #1912 for revisiting isTrusted usage
* #1913 for updating synthetic mouse events
* #1922 for making more events composed
@annevk
Copy link
Member Author

annevk commented Oct 19, 2016

@sendilkumarn the PR landed, you can work on this now.

@sendilkumarn sendilkumarn mentioned this issue Oct 19, 2016
Merged
@annevk annevk closed this as completed in 3d19b31 Oct 21, 2016
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Editorial: major cleanup around firing and dispatching events
36f4331 
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes whatwg#1713, but plenty of follow up issues remain:

* whatwg#805 for the remainder of "default action" usage
* whatwg#1394 for updating synthetic click events
* whatwg#1887 for removing "fire a simple event" usage
* whatwg#1893 for updating when checkboxes get checked
* whatwg#1900 for figuring out if event dispatch requires more hooks
* whatwg#1912 for revisiting isTrusted usage
* whatwg#1913 for updating synthetic mouse events
* whatwg#1922 for making more events composed
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@sendilkumarn
Editorial: "fire a simple event" is now "fire an event"
34fac86 
Fixes whatwg#1887.
anssiko added a commit to w3c/presentation-api that referenced this issue Jun 27, 2019
@anssiko
Update [HTML51] and [HTML52] references to [HTML]
feab06c 
Apart from direct mapping:

- "firing an event" concept moved to [DOM]
- "firing a simple event named e" concept replaced with "fire an event" in whatwg/html#1887
- "sandboxed top-level navigation browsing context flag" is now forked into "with user gesture" and "without user gesture",
  "without user gesture" seems appropriate here. Historical context: #414

Fix #464
@anssiko anssiko mentioned this issue Jun 27, 2019
Merged
anssiko added a commit to w3c/presentation-api that referenced this issue Jun 27, 2019
@anssiko
Update [HTML51] and [HTML52] references to [HTML]
f552cca 
Apart from direct mapping:

- "firing an event" concept moved to [DOM]
- "firing a simple event named e" concept replaced with
  "fire an event" in whatwg/html#1887
- "sandboxed top-level navigation browsing context flag" is now
  forked into "with user gesture" and "without user gesture",
  "without user gesture" seems appropriate here.
  Historical context: #414

Fix #464
markafoltz pushed a commit to w3c/presentation-api that referenced this issue Aug 14, 2019
@anssiko @markafoltz
Update [HTML51] and [HTML52] references to [HTML] (#465)
5f5a8f3 
Apart from direct mapping:

- "firing an event" concept moved to [DOM]
- "firing a simple event named e" concept replaced with
  "fire an event" in whatwg/html#1887
- "sandboxed top-level navigation browsing context flag" is now
  forked into "with user gesture" and "without user gesture",
  "without user gesture" seems appropriate here.
  Historical context: #414

Fix #464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project topic: events
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @annevk @sendilkumarn