Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic mouse event and detail being 1 #1913

Closed
annevk opened this issue Oct 17, 2016 · 1 comment
Closed

Synthetic mouse event and detail being 1 #1913

annevk opened this issue Oct 17, 2016 · 1 comment
Labels
compat Standard is not web compatible or proprietary feature needs standardizing topic: events

Comments

@annevk
Copy link
Member

annevk commented Oct 17, 2016

HTML has two usages of synthetic mouse events, click() and friends, and contextmenu. For click(), detail is zero in implementations as far as I can tell. I'm not sure how to test the synthetic contextmenu event.

But something is wrong here. Filing this as follow up to #1886 since it seems bad to make actual normative changes there.

(We use "compat" for mismatches with implementations too right?)
@annevk annevk added the compat Standard is not web compatible or proprietary feature needs standardizing label Oct 17, 2016
domenic pushed a commit that referenced this issue Oct 18, 2016
@annevk @domenic
Editorial: major cleanup around firing and dispatching events
8ffbd14 
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes #1713, but plenty of follow up issues remain:

* #805 for the remainder of "default action" usage
* #1394 for updating synthetic click events
* #1887 for removing "fire a simple event" usage
* #1893 for updating when checkboxes get checked
* #1900 for figuring out if event dispatch requires more hooks
* #1912 for revisiting isTrusted usage
* #1913 for updating synthetic mouse events
* #1922 for making more events composed
@annevk
Copy link
Member Author

annevk commented Oct 25, 2016

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4603 logs 0 for click(), 1 for mouse click, and 0 for right click / ctrl + mouse click (both trigger contextmenu on macOS).

annevk added a commit that referenced this issue Oct 25, 2016
@annevk
Stop overriding UIEvent's detail attribute
58241d2 
Per the example in #1913 it is not ever initialized to 1 when
dispatched synthetically. And its default is already 0. Fixes #1913.
@annevk annevk mentioned this issue Oct 25, 2016
Merged
domenic pushed a commit that referenced this issue Oct 25, 2016
@annevk @domenic
Stop overriding UIEvent's detail attribute
bd3239b 
Per the example in #1913 it is not ever initialized to 1 when
dispatched synthetically. And its default is already 0. Fixes #1913.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Editorial: major cleanup around firing and dispatching events
36f4331 
This aligns firing and dispatching of events with updated terminology in
the DOM Standard. Among the changes:

* A lot less usage of "default action" which isn't really a thing.
  Instead we make use of the return value of the fire and dispatch
  algorithms.
* Instead of saying things bubble or are cancelable we initialize the
  attributes as such.
* We no longer re-state defaults for isTrusted, bubbles, and cancelable,
  as that only leads to confusion when they are *not* re-stated.
* We now use the legacy target override flag rather than supplying a
  named argument.

This fixes whatwg#1713, but plenty of follow up issues remain:

* whatwg#805 for the remainder of "default action" usage
* whatwg#1394 for updating synthetic click events
* whatwg#1887 for removing "fire a simple event" usage
* whatwg#1893 for updating when checkboxes get checked
* whatwg#1900 for figuring out if event dispatch requires more hooks
* whatwg#1912 for revisiting isTrusted usage
* whatwg#1913 for updating synthetic mouse events
* whatwg#1922 for making more events composed
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Stop overriding UIEvent's detail attribute
bf427bc 
Per the example in whatwg#1913 it is not ever initialized to 1 when
dispatched synthetically. And its default is already 0. Fixes whatwg#1913.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat Standard is not web compatible or proprietary feature needs standardizing topic: events
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk