Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a [[IsHTMLDDA]] internal slot to document.all #3015

Closed
TimothyGu opened this issue Sep 7, 2017 · 2 comments
Closed

Add a [[IsHTMLDDA]] internal slot to document.all #3015

TimothyGu opened this issue Sep 7, 2017 · 2 comments
Labels
topic: script

Comments

@TimothyGu
Copy link
Member

Now that tc39/ecma262#673 has been merged, we should add the newly defined [[IsHTMLDDA]] internal slot to either document.all specifically or HTMLAllCollection instances generically -- they are equivalent. I personally prefer adding it to HTMLAllCollection, where other obsoleted features like legacy caller behavior are specified.

Refs: https://tc39.github.io/ecma262/#sec-IsHTMLDDA-internal-slot
@TimothyGu TimothyGu changed the title Add a [[IsHTMLDDA]] Add a [[IsHTMLDDA]] internal slot to document.all Sep 7, 2017
@annevk
Copy link
Member

annevk commented Sep 7, 2017

Maybe this can be done as part of #2932?

@TimothyGu
Copy link
Member Author

@annevk It could be, but I'd rather not. They are logically distinct changes.

@TimothyGu TimothyGu mentioned this issue Sep 8, 2017
Closed
2 tasks
TimothyGu added a commit to TimothyGu/html that referenced this issue Oct 2, 2017
@TimothyGu
Define document.all as having [[IsHTMLDDA]]
e324acc 
Fixes whatwg#3015.
@TimothyGu TimothyGu mentioned this issue Oct 2, 2017
Merged
annevk pushed a commit that referenced this issue Oct 2, 2017
@TimothyGu @annevk
Define document.all as having [[IsHTMLDDA]]
542be55 
Fixes #3015.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@TimothyGu
Define document.all as having [[IsHTMLDDA]]
ebd5af0 
Fixes whatwg#3015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: script
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @TimothyGu @annevk