Define document.all as having [[IsHTMLDDA]] #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Oct 2, 2017
source
Outdated
| @@ -3056,6 +3056,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <li>The <dfn data-x-href="https://tc39.github.io/ecma262/#sec-sharedarraybuffer-objects"><code>SharedArrayBuffer</code></dfn> class</li> | |||
| <li>The <dfn data-x-href="https://tc39.github.io/ecma262/#sec-native-error-types-used-in-this-standard-typeerror"><code>TypeError</code></dfn> class</li> | |||
| <li>The <dfn data-x="js-RangeError" data-x-href="https://tc39.github.io/ecma262/#sec-native-error-types-used-in-this-standard-rangeerror"><code>RangeError</code></dfn> class</li> | |||
| <li>The <dfn data-x="js-IsHTMLDDA" data-x-href="https://tc39.github.io/ecma262/#sec-IsHTMLDDA-internal-slot">[[IsHTMLDDA]]</dfn> internal slot</li> | |||
There was a problem hiding this comment.
We've kind of stoppped adding data-x's for most JS things. This makes them a bit easier to link to.
source
Outdated
| <span data-x="js-IsHTMLDDA">[[IsHTMLDDA]]</span> internal slot.</p> | ||
|
|
||
| <div class="note"> | ||
|
|
There was a problem hiding this comment.
We've also kind of moved away from extra newlines between opening/closing tags and their contents. So here and for the ul, best to remove those.
|
@domenic Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3015.
One less willful violation!