Host whatwg.org #20
Host whatwg.org #20
Conversation
foolip
force-pushed
the
host-whatwg.org
branch
from
efd7c1d to
6b40550
Compare
|
This now depends on #25. @sideshowbarker, can you review the commits except the first? (Currently 2.) |
test/redirects.js
Outdated
| ['http://wiki.whatwg.org/', 302, 'https://wiki.whatwg.org/', 'keep'], | ||
| ['http://www.whatwg.org/foo', 404], // TODO | ||
| ['http://www.whatwg.org/', 301, 'https://www.whatwg.org/', 'keep'], |
There was a problem hiding this comment.
Why not make this skip straight to no-www?
There was a problem hiding this comment.
That would violate HSTS preload guidelines.
There was a problem hiding this comment.
Basically, you first redirect to the identical secure URL and then do whatever else. It makes some sense as that's what HSTS does too internally. This is also why I was interested in testing http://whatwg.org/c.
There was a problem hiding this comment.
Also, it's a lot easier to always redirect to exactly the same resource on HTTPS.
| # There are many files with no extension, and a lot of default_type | ||
| # directives to get it right. The default is text/html. | ||
| default_type text/html; | ||
| charset utf-8; |
There was a problem hiding this comment.
charset utf-8;
We should be setting this for all hosts, in debian/marquee/nginx/conf/whatwg.conf.
Right now, because we’re not, all our .html, .js, .css content is being served with Content-Type headers that have no charset param.
There was a problem hiding this comment.
charset utf-8;
We should be setting this for all hosts, in
debian/marquee/nginx/conf/whatwg.conf.Right now, because we’re not, all our .html, .js, .css content is being served with
Content-Typeheaders that have nocharsetparam.
I raised #26 for that — and also to ensure we serve .js files as text/javascript (instead of the nginx default of application/javascript).
And for that see the related issue at https://trac.nginx.org/nginx/ticket/1407
There was a problem hiding this comment.
That's now fixed, so I'll delete it here. Thanks!
This is a conversion of .htaccess files (not just one) in: https://github.com/whatwg/whatwg.org/tree/master/whatwg.org CGI scripts are deliberately broken. Caching directories are ignored on the assumption that the nginx defaults are OK.
foolip
force-pushed
the
host-whatwg.org
branch
from
6b40550 to
751239a
Compare
|
Ah, I missed that this was approved. I'll merge as it was when it was approved, ask for the DNS change, and fiddle with the other changes separately. |
This reverts commit 5b95002.
No description provided.