Use mocha for cert/redirect tests and add content-type tests #25
Conversation
Rename the directory to test to match the mocha convention, even though the package.json is inside the directory and the test path (*.js) is given explicitly there.
|
This can be seen working in https://travis-ci.org/whatwg/misc-server/builds/294578969, which worked before I dropped aa66797 from the branch. |
.travis.yml
Outdated
| before_install: | ||
| - cd test | ||
| install: | ||
| - npm install |
There was a problem hiding this comment.
This shouldn't be necessary; it's implied by node_js
.travis.yml
Outdated
| script: | ||
| - ./run-tests.sh | ||
| - npm test |
test/certs.js
Outdated
| try { | ||
| const cert = await request; | ||
| for (const domain of DOMAINS) { | ||
| it(domain, async function() { |
There was a problem hiding this comment.
Nit: I like using specify here instead of it; they are equivalent but since you're not doing it("should do X", ...) it reads better.
There was a problem hiding this comment.
Good, I didn't like it or understand what it meant, but didn't know there was an option.
| ['https://whatwg.org/demos/repeat-02/results.xml', 'application/xml'], | ||
| ]; | ||
|
|
||
| const WITHOUT_EXTENSION_TESTS = [ |
There was a problem hiding this comment.
Is this meant to be comprehensive? Seems a pain to keep this in sync every time we add a file....
There was a problem hiding this comment.
It's all extensionless files I could find currently, but no, I don't think we should keep updating this, I think we should stop adding such files, or at least only use it for HTML for pretty URLs.
test/content-type.js
Outdated
| ['https://whatwg.org/specs/web-forms/2004-12-10-call-for-comments/sample-multiple-editable-ui', 'image/png'], | ||
| ['https://whatwg.org/specs/web-forms/2004-12-10-call-for-comments/xforms-implementation-diagram', 'image/png'], | ||
| // much more of the same... | ||
| /* |
There was a problem hiding this comment.
Why keep this commented-out block?
There was a problem hiding this comment.
I wanted to make the tests run a bit faster by skipping some bits. And easier testing of everything when doing the nginx setup. But between deleting and including, I think I'll just run all of the tests, and maybe we can make this smaller later using http://nginx.org/en/docs/http/ngx_http_core_module.html#try_files.
This reverts commit d9415f3.
|
OK, all fixed I think, added some more things I found in #7. https://travis-ci.org/whatwg/misc-server/builds/294777142 passed before I reverted the .travis.yml change. |
The redirects are translated from the .htaccess deleted in whatwg/url#351 and tested in #25.
The redirects are translated from the .htaccess deleted in whatwg/url#351 and tested in #25.
Rename the directory to test to match the mocha convention, even though
the package.json is inside the directory and the test path (*.js) is
given explicitly there.