-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions build.yml template #14
Conversation
Also remove any files that are part of the Travis setup. Part of whatwg/meta#173.
This probably needs exceptions for streams and encoding at least, to not generate a deploy.yml for them since they are special. |
It looks like encodings is different only in that it requires Python 3.8, but https://github.com/actions/virtual-environments/blob/master/images/linux/Ubuntu2004-README.md already has 3.8. It's not as locked down as picking a version we want using |
For streams there's already an exception to not process it at all in |
That shouldn't stay there for much longer, since whatwg/streams#1035 is now merged. |
I've tweaked this a bit and it seems to work when run: Sort of, one can tell from the directory names that something's wrong. |
I've fixed a problem and created some more PRs using the branch which look good: I think this is ready to land now, I don't want to create more PRs without landing the existing ones and confirm them working, in case some additional tweaks are needed. |
This makes the .travis.yml like the other repos to make changes from whatwg/spec-factory#14 smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me, but when looking at whatwg/dom it didn't seem to be working to me.
Blush. After the first two worked I eagerly commented before the second two had finished on the assumption they would run. I'll investigate why the did not. |
Explaining the appearance of Travis being stuck on multiple PRs, as in whatwg/compat#126 (comment). For most repos the Travis status is required by branch protection. That makes the status appear to be pending even though it won't be triggered. For each repo I handle, I'll update the branch protection as I land the change. |
Also remove any files that are part of the Travis setup.
Part of whatwg/meta#173.