Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions build.yml template #14

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 11, 2020

Also remove any files that are part of the Travis setup.

Part of whatwg/meta#173.

Also remove any files that are part of the Travis setup.

Part of whatwg/meta#173.
@domenic
Copy link
Member

domenic commented Jun 11, 2020

This probably needs exceptions for streams and encoding at least, to not generate a deploy.yml for them since they are special.

@foolip
Copy link
Member Author

foolip commented Jun 11, 2020

It looks like encodings is different only in that it requires Python 3.8, but https://github.com/actions/virtual-environments/blob/master/images/linux/Ubuntu2004-README.md already has 3.8. It's not as locked down as picking a version we want using actions/setup-python@v2, but is likely to work fine in practice. The same with anything needing node, actually, since some version is available by default.

@foolip
Copy link
Member Author

foolip commented Jun 11, 2020

For streams there's already an exception to not process it at all in factory.py, so that one's OK.

@andreubotella
Copy link
Member

andreubotella commented Jun 11, 2020

For streams there's already an exception to not process it at all in factory.py, so that one's OK.

That shouldn't stay there for much longer, since whatwg/streams#1035 is now merged.

@foolip
Copy link
Member Author

foolip commented Jun 11, 2020

I've tweaked this a bit and it seems to work when run:
whatwg/encoding#218
whatwg/fullscreen#175

Sort of, one can tell from the directory names that something's wrong.

@foolip foolip changed the title Add GitHub Actions deploy.yml template Add GitHub Actions build.yml template Jun 12, 2020
@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

I've fixed a problem and created some more PRs using the branch which look good:
whatwg/compat#126
whatwg/console#178
whatwg/dom#872
whatwg/fetch#1037

I think this is ready to land now, I don't want to create more PRs without landing the existing ones and confirm them working, in case some additional tweaks are needed.

foolip added a commit to whatwg/streams that referenced this pull request Jun 12, 2020
This makes the .travis.yml like the other repos to make changes from
whatwg/spec-factory#14 smaller.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, but when looking at whatwg/dom it didn't seem to be working to me.

@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

Blush. After the first two worked I eagerly commented before the second two had finished on the assumption they would run. I'll investigate why the did not.

@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

Explaining the appearance of Travis being stuck on multiple PRs, as in whatwg/compat#126 (comment).

For most repos the Travis status is required by branch protection. That makes the status appear to be pending even though it won't be triggered. For each repo I handle, I'll update the branch protection as I land the change.

@foolip foolip merged commit 7a4ea48 into master Jun 12, 2020
@foolip foolip deleted the github-actions-template branch June 12, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants