Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate no trailing .git when determining SHORTNAME #325

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

foolip
Copy link
Member

@foolip foolip commented Jun 12, 2020

No description provided.

@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

Yes, this is an hilarious amount of escaping!

@annevk
Copy link
Member

annevk commented Jun 12, 2020

Why is this needed?

I'm wondering if it would be better to hardcode the couple of exceptions we have here with respect to shortname in factory.json and propagate it as input parameter.

@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

This is because Travis clones repos with a trailing .git and GitHub Actions has not trailing .git.

I tested the before/after on GitHub Actions here:
https://github.com/whatwg/whatwg.org/runs/765365436?check_suite_focus=true
https://github.com/whatwg/whatwg.org/runs/765546248?check_suite_focus=true

This could also be done using the GITHUB_REPOSITORY environment variable, but we'd still need something for local deployment. Or we could just use the directory name for local deployment, right?

@annevk
Copy link
Member

annevk commented Jun 12, 2020

Sorry, I was thinking about the wrong thing. We should probably indicate we can clean this up post-transition.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But consider adding a comment to remind us to simplify once Travis isn't a dependency anymore.

@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

I'll send a follow-up that does something much simpler for GitHub Actions. The other path will then be for local, where it actually makes sense to handle both cases, and will continue to work on Travis.

@foolip foolip merged commit d3bcf77 into master Jun 12, 2020
@foolip foolip deleted the shortname-trailing-dot-git branch June 12, 2020 14:45
@foolip
Copy link
Member Author

foolip commented Jun 12, 2020

Sent #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants