Expose ProgressEvent to ServiceWorker

[saschanaz]

FileReader is exposed to ServiceWorker and uses ProgressEvent, but the event interface is not exposed to ServiceWorker since 9d0a9bb.

Exposing it to ServiceWorker also matches Gecko and WebKit implementation:

• Gecko https://searchfox.org/mozilla-central/rev/2aea8e093c3c6d10bc3f385e0ea66b6387221e71/dom/webidl/ProgressEvent.webidl
• WebKit https://webkit-search.igalia.com/webkit/rev/7418d7c94bd380d0844789d128e5805e28d9c572/Source/WebCore/dom/ProgressEvent.idl

[annevk]

I guess it's too late to stop doing that?

@asutherland @mkruisselbrink @jakearchibald

[mkruisselbrink]

"that" being exposing FileReader to service workers? Now all major browsers have implemented Blob.stream/text/arrayBuffer there at least is an alternative to FileReader (other than wrapping a Blob in a Response). My gut feeling is that actually removing FileReader from service workers would be challenging though.

[annevk]

Yeah, removing FileReader. If it's too late I support doing this.

[Rashika101]

Hey!!
Are you willing to accept new contributors? I am interested into contributing to this repository so, if you could explain a bit more this feature request, it would be great.
Thanks

[saschanaz]

xhr/xhr.bs

Lines 1764 to 1765 in b7726ee

	[Exposed=(Window,DedicatedWorker,SharedWorker)]
	interface ProgressEvent : Event {

Currently the line 1764 lacks ServiceWorker, so we need to add one. I don't think we need anything other than that 👍

[Rashika101]

Hey!! I wanna do that will you please assigned this issue to me that will be great .

[saschanaz]

I don't think assigning is used in this repo. Just open a PR and make sure you include Fixes #305 in the description 😉. It will automatically link your PR to this issue.

[Rashika101]

Thank You
@saschanaz
but what is fixed in Fixes #305.
If You don't mind Could You please explain little deeper.

[saschanaz]

Hmm, I mean when you open a pull request after writing the actual fix, you'll want to include the "Fixes" text to the content body of the post. It's not a requirement but just a recommendation, so if you have no idea please just proceed.

[Rashika101]

Understood...But no Description box is coming.
written -"there isn't nothing to compare"
How to do that?

[saschanaz]

You committed the fix and you see that message? Weird, could you share the screenshot?

[Rashika101]

Can we please start it again?
Excuse me!! But I just got confused...
How to add a service Worker? I did in my own way...which is not adjusting with the repo.
Please teach me a little more..

[saschanaz]

No problem! The easiest way:

1. Open https://github.com/whatwg/xhr/blob/main/xhr.bs
2. Click the edit button at the right side (which looks like a pen)
3. Search interface ProgressEvent and add ,ServiceWorker to the previous line
4. At the "Propose changes" block, write a title e.g. "Expose ProgressEvent to ServiceWorker"
5. Click "Propose changes" button.
6. Cilck "Create pull request"
7. Type "x" inside [ ] so that it can be [x], for "At least two implementers are interested" part, and replace "..." with "Gecko" and "WebKit". This is based on my observation in Expose ProgressEvent to ServiceWorker #305 (comment). (You can skip this.)
8. Cilck "Create pull request" again
9. That's it!

I'll happily write steps for GitHub Desktop if you are using it BTW.

[Rashika101]

@saschanaz
Thank You so so much ..
I did that..
What next to do?