Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .toc files when ripping a CD multiple times due to whipper ToC caching #486

Closed
the-confessor opened this issue May 17, 2020 · 4 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Status: blocked Issue is blocked on another issue
Milestone

Comments

@the-confessor
Copy link

Most of the CDs I have ripped with whipper have a .toc file, but a handful of them don't. I haven't been able to establish a pattern behind it.

What is the intended behavior - always create a .toc file, or only under certain conditions? If the latter then what are the conditions?

@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label May 29, 2020
@JoeLametta
Copy link
Collaborator

JoeLametta commented May 29, 2020

What is the intended behavior - always create a .toc file, or only under certain conditions?

Whipper should always† create the toc files: if it doesn't it means there's a bug somewhere...

† Caching data of already ripped CDs in whipper may cause this (#335). If that's the case you could try deleting whipper's cache folder ($XDG_CACHE_HOME/.cache/whipper/ or ~/.cache/whipper/) then ripping again.

Is this issue reproducible multiple times against the same CD?

@the-confessor
Copy link
Author

It is reproducible multiple times with the same CD.

Clearing the cache does work around the issue.

I think I see a pattern. The affected rips are all ones where I ended up ripping the CD more than once. If I do the following I am able to reproduce the issue.

  1. Rip a CD.
  2. Inspect the ripped CD folder. Notice there is a .toc file.
  3. Delete the ripped CD folder.
  4. Rip the same CD again.
  5. Inspect the ripped CD folder. This time there is not .toc file.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Status: blocked Issue is blocked on another issue labels Jun 6, 2020
@JoeLametta
Copy link
Collaborator

JoeLametta commented Jun 6, 2020

Thanks for the test: that seems to confirm the caching hypothesis.
Relevant links:

@JoeLametta JoeLametta changed the title missing .toc files? Missing .toc files when ripping a CD multiple times due to whipper ToC caching Jun 6, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Jun 6, 2020
@JoeLametta
Copy link
Collaborator

Hi, this should now be fixed thanks to pull request 336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Status: blocked Issue is blocked on another issue
Projects
None yet
Development

No branches or pull requests

2 participants