Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop whipper caching #335

Closed
JoeLametta opened this issue Nov 17, 2018 · 0 comments · Fixed by #336
Closed

Drop whipper caching #335

JoeLametta opened this issue Nov 17, 2018 · 0 comments · Fixed by #336
Assignees
@JoeLametta
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: patch A pull request is required Priority: medium Medium priority Status: in progress Issue/pull request which is currently being worked on
Milestone
1.0

Comments

@JoeLametta
Copy link
Collaborator

JoeLametta commented Nov 17, 2018 •
edited
Loading

Whipper's caching implementation causes a few issues (#196, #230, #321 (comment)) and complicates the code: it's better to drop this feature.
@JoeLametta JoeLametta added this to the 1.0 milestone Nov 17, 2018
This was referenced Nov 19, 2018
Merged
Closed
@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap Priority: medium Medium priority Needed: patch A pull request is required labels Nov 19, 2018
@JoeLametta JoeLametta changed the title Drop whipper ToC/AccurateRip caching Drop whipper caching Nov 21, 2018
@JoeLametta JoeLametta mentioned this issue Nov 21, 2018
Merged
@JoeLametta JoeLametta self-assigned this Nov 21, 2018
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Nov 21, 2018
@JoeLametta JoeLametta mentioned this issue May 29, 2020
Closed
JoeLametta added a commit that referenced this issue Sep 17, 2020
@JoeLametta
Drop whipper caching (#336)
3acc3ff 
Whipper's caching implementation causes a few issues (#196, #230, [#321 (comment)](#321 (comment))) and complicates the code: it's better to drop this feature.

The rip resume feature doesn't work anymore: if possible it will be restored in the future.

* Remove caching item from TODO
* Delete unneeded files related to caching
* Update 'common/directory.py' & 'test/test_common_directory.py' (caching removal)
* Update 'common/accurip.py' & 'test/test_common_accurip.py' (caching removal)
* Update 'common/program.py' (caching removal)
* Update 'command/cd.py' (caching removal)

This fixes #335, fixes #196 and fixes #230.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@Forage Forage mentioned this issue May 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Needed: patch A pull request is required Priority: medium Medium priority Status: in progress Issue/pull request which is currently being worked on
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Drop whipper caching whipper-team/whipper
1 participant
@JoeLametta