-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttributeError: 'Namespace' object has no attribute 'offset' #230
Comments
Reproduced on Solus, with whipper 0.6.0 and Python 2.7.14
|
Interesting comment by @RecursiveForest (link):
Shall we attempt to fix this for milestone 1.0? |
Same issue here. Ubuntu 18.04, Whipper 0.7.0
|
I can reproduce the issue running 0.7.0 on the number-one distro for script kiddies. I explicitly passed the drive offset in order to work around the issue mentioned by @thwaller but ran into another error:
The album is obscure enough to be considered identifying information and has thus been redacted. If a developer requires a full error log, please let me know, and I will provide it privately. The cd-paranoia error is as follows. The offset of 667 was obtained by EAC. I will dig up an album that is in the AccurateRip database to see what whipper thinks.
... aaaand I dug up an album just to see yet another error. My drive's offset as reported by 42 other users is 667, by the way. Sorry, but this is where I tap out. In any case, the main bug (certainly not ALL of them) could be with cd-paranoia. I will consider reporting there when I have more information (and energy).
As a final note, here was the command whipper issued that should have succeeded but failed, followed by a modified command that did succeed:
This should probably be considered its own issue (or issues) at this point. Please move/reference this post as necessary. |
Whipper's caching implementation causes a few issues (#196, #230, [#321 (comment)](#321 (comment))) and complicates the code: it's better to drop this feature. The rip resume feature doesn't work anymore: if possible it will be restored in the future. * Remove caching item from TODO * Delete unneeded files related to caching * Update 'common/directory.py' & 'test/test_common_directory.py' (caching removal) * Update 'common/accurip.py' & 'test/test_common_accurip.py' (caching removal) * Update 'common/program.py' (caching removal) * Update 'command/cd.py' (caching removal) This fixes #335, fixes #196 and fixes #230. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
whipper.log.gz
The text was updated successfully, but these errors were encountered: