Drop whipper caching #336
Merged
Drop whipper caching #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
a2eec4c
to
be954c8
Compare
Freso
requested changes
Nov 21, 2018
There was a problem hiding this comment.
I love how much code this gets rid of. Seems like it will make the code simpler indeed. One small wording (docstring) change and please also just get rid of the cache_path() stuff. It's not used anywhere anymore according to git grep.
I haven't tested this though, just reviewed it "by eye", so it may well break everything. 😂 I'll try and find some time to run a rip using this branch.
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
be954c8
to
8c918b6
Compare
|
Regarding to the rip resume thing I think it may work without caching too but the logfile is going to miss some information about the tracks which have been already ripped. 1:
Filename: /path/to/track.flac
Pre-gap length: 00:00:50
Peak level: 0.1234567
Pre-emphasis: No
Extraction speed: 1.2 X
Extraction quality: 100.00 %
Test CRC: 0CFA7ABF
Copy CRC: 0CFA7ABF
AccurateRip v1:
Result: Found, exact match
Confidence: 9
Local CRC: CD2E3B53
Remote CRC: CD2E3B53
AccurateRip v2:
Result: Found, exact match
Confidence: 19
Local CRC: 3D05ABCF
Remote CRC: 3D05ABCF
Status: Copy OK |
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
2 times, most recently
from
18f971c
to
ab4e7f4
Compare
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
ab4e7f4
to
e8712e5
Compare
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
2 times, most recently
from
1faa9de
to
7009329
Compare
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
3 times, most recently
from
d109a43
to
68d4bb6
Compare
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
68d4bb6
to
0a9e456
Compare
|
Rebased (fixed merge conflicts). |
1 similar comment
|
Rebased (fixed merge conflicts). |
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
0a9e456
to
8f3c8c4
Compare
|
Fixed merge conflict. |
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
faed0a2
to
6c080f6
Compare
|
Fixed merge conflicts. |
|
Shall we revive this one? |
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
6c080f6
to
d4005bd
Compare
|
It would be cool to see this get merged. 😄 |
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
d4005bd
to
2755227
Compare
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
…ng removal) Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
…emoval) Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
JoeLametta
force-pushed
the
bugfix/issue-335-drop-caching
branch
from
2755227
to
7be8ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whipper's caching implementation causes a few issues (#196, #230, #321 (comment)) and complicates the code: it's better to drop this feature.
This fixes #335, fixes #196 and fixes #230.