Concatenation adapter

[Finesse]

I've made a new adapter. It joins the results of adapter instances into a single adapter.

use Pagerfanta\Adapter\ArrayAdapter;
use Pagerfanta\Adapter\ConcatenationAdapter;
use Pagerfanta\Adapter\MongoAdapter;

$adapter = new ConcatenationAdapter(array(
    new ArrayAdapter(array('ad1', 'ad2')),
    new MongoAdapter(/* cursor */)
));

[Finesse]

It considers all the remarks from #218, #208 and #194

[sampart]

This is a great PR. Just a handful of minor changes please. Thanks again for contributing.

[sampart]

This is quite hard to read. Please could you use sprintf instead?

[Finesse]

✅ Is it good now?

[sampart]

Could you update this comment to be The requested range peeps below the bottom edge of the adapter range? (above to below). That would be clearer.

[Finesse]

@sampart You are right. The comment describes the following situation:

                       0 1 2 3 4 5 6 7 8 9 10
Current adapter range:     |  [4   |     9]
Requested range:          [2       6]  

✅ I've changed the comments and the variables names to make the code more clear.

[sampart]

Since you submitted this PR, we've merged #240, which uses namespaced PHPUnit files. Please could you change this line to be class ConcatenationAdapterTest extends TestCase and add the following use statement?

use PHPUnit\Framework\TestCase;

[Finesse]

✅

[sampart]

Looks great, thanks!

[Finesse]

@sampart I’m glad to read your feedback. Thank you!

[Finesse]

@sampart And thank you for supporting Pagerfanta, it’s a great library.

[sampart]

Thanks for the kind words, @FinesseRus (and for your contributions!)