Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use namespaced TestCase #240

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Use namespaced TestCase #240

merged 1 commit into from
Oct 17, 2017

Conversation

MarioBlazek
Copy link
Contributor

This PR resolves:

  • test classes now extend from PHPUnit\Framework\TestCase rather than PHPUnit_Framework_TestCase

sampart
sampart reviewed Oct 17, 2017
View reviewed changes
Copy link
Collaborator

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just one question.

composer.json
@@ -14,7 +14,7 @@
"php": ">=5.3.0"
},
"require-dev": {
"phpunit/phpunit": "~4 | ~5",
"phpunit/phpunit": "^4.8.35 | ^5.7",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that you're using such specific versions because it's only in these (and above) that the PHPUnit files are in namespaces?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the forward compatibility layer was backported in the 4.8 branch for the 4.8.35 release. Older 4.8 versions don't have it.

Technically, PHPUnit 5.5+ has the new classes, but anything before 5.7 in the 5.x branch is unmaintained anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for answering @stof

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both.

@sampart sampart merged commit c8af52c into whiteoctober:master Oct 17, 2017
@sampart
Copy link
Collaborator

sampart commented Oct 17, 2017

Merged! Thanks again, @MarioBlazek

@MarioBlazek
Copy link
Contributor Author

Thank you @sampart

@sampart sampart mentioned this pull request Oct 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@sampart sampart sampart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarioBlazek @sampart @stof