Skip to content

Commit

Permalink
xfd/warn/block: Remove 10k z-index on select2 dropdowns
Browse files Browse the repository at this point in the history
Per follow-up in wikimedia-gadgets#971 from the addition in wikimedia-gadgets#692, these appear unnecessary.
  • Loading branch information
Amorymeltzer authored and wiki-ST47 committed Sep 2, 2020
1 parent ce917b2 commit 23ac1f3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions modules/twinkleblock.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,6 @@ Twinkle.block.callback.change_action = function twinkleblockCallbackChangeAction
});

mw.util.addCSS(
// prevent dropdown from appearing behind the dialog, just in case
'.select2-container { z-index: 10000; }' +
// Reduce padding
'.select2-results .select2-results__option { padding-top: 1px; padding-bottom: 1px; }' +
// Adjust font size
Expand Down
3 changes: 0 additions & 3 deletions modules/twinklewarn.js
Original file line number Diff line number Diff line change
Expand Up @@ -1312,9 +1312,6 @@ Twinkle.warn.callback.postCategoryCleanup = function twinklewarnCallbackPostCate
$('.select2-selection').keydown(Morebits.select2.autoStart);

mw.util.addCSS(
// prevent dropdown from appearing behind the dialog, just in case
'.select2-container { z-index: 10000; }' +

// Increase height
'.select2-container .select2-dropdown .select2-results > .select2-results__options { max-height: 350px; }' +

Expand Down
3 changes: 0 additions & 3 deletions modules/twinklexfd.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,6 @@ Twinkle.xfd.callback.change_category = function twinklexfdCallbackChangeCategory
});

mw.util.addCSS(
// prevent dropdown from appearing behind the dialog, just in case
'.select2-container { z-index: 10000; }' +

// Remove black border
'.select2-container--default.select2-container--focus .select2-selection--multiple { border: 1px solid #aaa; }' +

Expand Down

0 comments on commit 23ac1f3

Please sign in to comment.