-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
morebits: Remove tipsy dependency, use jQuery UI for tooltips #971
morebits: Remove tipsy dependency, use jQuery UI for tooltips #971
Conversation
8a7d14b
to
863557d
Compare
morebits.css
Outdated
.morebits-ui-tooltip | ||
{ | ||
padding: 4px 6px 4px 6px; | ||
font-size: 1.2em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font size within the tooltip is ENORMOUS at my end - looks like about 18px, not easily measurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19.2, yeah. This is annoying skin shit. I was aiming for 12 px, but they behave differently. For a quick example:
- Vector:
0.8em
of100%
= 12.8px - Timeless:
1.1em
of 0.95em` = 16.72px - Modern:
1.1em
ofx-small
= 11px
There's a second issue, though. 12px looks a little small on Vector, because it has font-family: sans-serif
whereas 13px is a little big on Modern and Timeless, because they both have font-family: Verdana,Arial,sans-serif
.
YMMV, but IMO 13px
looks better on Modern and Timeless than 12px
does on Vector (and we should be favoring Vector anyway). rem
and %
are no help AFAICT.
font-size: 1.2em; | |
font-size: 13px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default (without any font-size
set) looks good to me on vector, monobook and modern. For timeless, it's huge but easily restored back to normal by putting something like
.skin-timeless .morebits-ui-tooltip {
font-size: 13px;
}
Also, the tooltip is hiding behind the select2 dropdowns when they're open. |
863557d
to
e4ca005
Compare
Well, we do have We could just set the z-index to something similarly asinine (100000 or 10001), or really investigate whether we really still/ever needed the select2 z-index. |
Yeah, can't trigger any issues after removing the z-index on the select2 dropdowns; feel free to remove that. |
110dd9e
to
f3bf2f9
Compare
Per follow-up in wikimedia-gadgets#971 from the addition in wikimedia-gadgets#692, these appear unnecessary.
f3bf2f9
to
055a6a3
Compare
There do appear to be a number of scripts that assume
I left a note for WK on the talkpage, but I don't perceive this to be a problem or hindrance to removal. |
055a6a3
to
b319e0e
Compare
This harkens back to the homegrown tooltips that were replaced by tipsy (a14f46f, 2011), mainly because we've still been defining the CSS! Some tweaks were made: with a decade of black, I figured blue would be too bright, so mediumblue was used. The classes are changed, but there should only be minor differences in appearance. https://api.jqueryui.com/tooltip/
b319e0e
to
cefc232
Compare
Was only used for the tipsy tooltips, removed in cefc232 / wikimedia-gadgets#971; unused elsewhere
Per follow-up in wikimedia-gadgets#971 from the addition in wikimedia-gadgets#692, these appear unnecessary.
This harkens back to the homegrown tooltips that were replaced by tipsy (a14f46f, 2011), mainly because we've still been defining the CSS! Some tweaks were made: with a decade of black, I figured blue would be too bright, so mediumblue was used (we could, of course, keep it black). There should only be minor differences in appearance. The classes are changed, but there's nobody using them (in fact, there are more instances of old morebits pages with the old, pre-tipsy style).
https://api.jqueryui.com/tooltip/