twinklewarn - Treat userlink properly for uw-aiv #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested, but would it work to call |
Amorymeltzer
force-pushed
the
warn-AIVsummaryfix
branch
from
e573e07 to
c225a8b
Compare
|
Putting it at the end of |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Jun 6, 2019
Closes wikimedia-gadgets#659. Changing changing a selection via `jquery.chosen` didn't trigger `change_subcategory`. We still need the extra `Twinkle.warn.callback.change_subcategory(e)` call from wikimedia-gadgets#432 to update display on simply `change_category` but I don't think we need the initial event in `sub_group` if we're using chosen
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Jun 6, 2019
Closes wikimedia-gadgets#659. Changing selection from a `jquery.chosen` menu doesn't trigger `change_subcategory` since the event was attached to the original select. We still need the extra `Twinkle.warn.callback.change_subcategory(e)` call from wikimedia-gadgets#432 to update display on simply `change_category` as well as the original, initial event in `sub_group` for users who opt-out of the new `jquery.chosen` display (wikimedia-gadgets#661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
The function to change the input label for certain warnings (change_subcategory) is only called when changing items in the submenu, so since uw-aiv is the first item, it won't show unless you change submenu items rather than the main category menu. This is obviously less-than-ideal, but still an improvement over the current situation.