warn: make jquery.chosen based menu optional, via-opt-out #661
Conversation
Per discussion at [[Wikipedia_talk:Twinkle#User_warning_dialog_dropdown_selector]]
|
Thoughts on making it opt-in rather than opt-out? |
|
I guess only the old hands, who are used to their ways, aren't liking it. New users should love it. I think it's better to keep it opt-out. |
|
@siddharthvp Issue there is that the old hands are the ones doing the majority of warnings and using Twinkle. |
Not inherently opposed, but its rather silly to have the feature-rich version off by default. I don't know, it gets tough to decide things between us. Can others who are watching pitch in? Or should we open a discussion on this at WT:TW?
Cool, have you tried that? |
|
We've had only two folks with complaints, and I've got at least two on IRC who are all for it, so I'll hold off a bit to see if there's more input, but I'm leaning toward opt-out of the new style as well. With a section at WT:TW and a linked comment at WP:VPT it should get noticed. ETA: three, two of which seem fine with opt-out |
I was playing around with that. See https://ibb.co/PT8b63Z. Removed the padding entirely off the top and bottom of the li elements. This looks much better and non-OOUI like, and may probably avoid the need to make the thing opt-out. Most people, including me, hate OOUI styles anyway. The trouble is the result was obtained by removing padding from chrome devtool's styles menu. I have no idea how to get that using code. I have wasted quite a silly amount of time trying it out with no success. Neither |
|
Yeah, I think I spoke too soon? I came up against the same thing as well. Even tried using
Preach. |
Amorymeltzer
changed the title
|
No more input so gonna go ahead and merge this. Thanks for being so quick on this @siddharthvp; it's not an ideal solution but so be it. |
Closes wikimedia-gadgets#659. Changing selection from a `jquery.chosen` menu doesn't trigger `change_subcategory` since the event was attached to the original select. We still need the extra `Twinkle.warn.callback.change_subcategory(e)` call from wikimedia-gadgets#432 to update display on simply `change_category` as well as the original, initial event in `sub_group` for users who opt-out of the new `jquery.chosen` display (wikimedia-gadgets#661)
Per discussion at [[Wikipedia_talk:Twinkle#User_warning_dialog_dropdown_selector]]
The reason some folks don't like this is because chosen makes the select menu much less denser, requiring more scrolling to get to the templates, and this also seems to give undue focus to
{{uw-part of the templates.