-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-17651] Add a new "Getting Started" archetype. #47
Conversation
* Rely on the provisioned server + deployments to run the integration tests * Use a single managed Arquillian container to run the tests * Do not use profiles for testing, with this settings, there is no reason that integration tests should be skipped. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Update testing strategy
to use the same package and prefix that the application classes. Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Update packaging of the projects tests
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Update generated project README
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* update the version property named "version.jboss.bom" | ||
* check whether dependencies have changed. | ||
* check the plugin versions and update if necessary: | ||
** wildfly-maven-plugin: https://repo.maven.apache.org/maven2/org/wildfly/plugins/wildfly-maven-plugin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use these links or the project thinks? Most maven plugins show he latest version on the top right of their site. Or in the case of the the wildfly-maven-plugin in it's on the left.
...-getting-started-archetype/src/main/resources/archetype-resources/src/main/webapp/index.html
Outdated
Show resolved
Hide resolved
public void testHelloEndpoint() { | ||
try (Client client = ClientBuilder.newClient()) { | ||
Response response = client | ||
.target(URI.create("http://localhost:8080/")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should inject a URL
or URI
with the @ArquillianResource
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get ridden of arquillian IMHO, it's dead/zombie project and it is not openshift compatible. We are moving on from it on QS and same should be done on archetypes imho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arquillian is the only solution we have to test CDI beans afaict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are going to advise users to go for something that won't be able to test on the cloud? We can use http, rest, etc for the test to interact with the app...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you test CDI bean in Jakarta EE application otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno, not even looking into that honestly :-) Just think that before you decide how to implement your testing you should ensure that the test can be run in all supported runtime scenarios. Arquillian is not just unsupported, and not under development, it also doesn't support such a critical priority named OpenShift. In the enhanced QS so far we have been relying only on http client to interact with the app, but like I said there are other clients/frameworks and even WFLY remote tools available to use... I know Arquillian looks cool and is kind of emotional but very strong reasoning to avoid it.
Signed-off-by: James R. Perkins <jperkins@redhat.com>
Use more modern JavaScript and some formatting changes
This follows on from #26, merges the latest changes from main and pulls in Jeff's latest changes from https://github.com/jmesnil/wildfly-archetypes/tree/darranl-WFLY-17651.