Add support for Symfony 3.3

[pierredup]

Since symfony/symfony#22010 there is now an extra argument to the translator constructor, which means the $options parameter moves one index up

[monteiro]

@pierredup thank you very much for your PR. Thanks to you we are supporting the next version of Symfony.

[craigh]

Hello @pierredup and @monteiro

I am trying to use this Bundle with Symfony 5.2-Beta2 and this line referencing the old number 3 arg is not working.

@pierredup I am wondering why you were merging the 3 arg with the 4 arg? can we just eliminate that line?

[stof]

The code should not be merging both arguments, but reading the right one.

[stof]

see Incenteev/translation-checker-bundle#11 for a solution

[pierredup]

It only merges the values to check for the resource_files option in either the 3rd or 4th argument in the compiler pass. It doesn't pass those merged options back to to the service

[stof]

@pierredup yeah, but this break if the other argument is not the options argument

[craigh]

see #293

[pierredup]

@stof how does it break? Was there another change in the signature in versions after 3.3?

[pierredup]

Okay I just read through all the linked issues. The issue here is not with SF >= 3.3, but rather 5.2 where the arguments are not resolved yet by the time this compiler pass runs.
And since this bundle don't support SF < 3.4 anymore, I think the compiler pass can be updated to just rely on the new signature and does'n have to worry about the old signature

[craigh]

this argument:

The issue here is not with SF >= 3.3, but rather 5.2 where the arguments are not resolved yet by the time this compiler pass runs

is opposite this argument:

I think the compiler pass can be updated to just rely on the new signature and does'n have to worry about the old signature

if the issue is the timing, then the order is correct. If the issue is the new signature order then timing doesn't matter.

[pierredup]

In Symfony < 5.2, the 4th argument (3rd index) was an array. In Symfony 5.2, that changed to be an instance of Symfony\Component\DependencyInjection\Argument\AbstractArgument.

This compiler pass runs before the Symfony\Component\Translation\DependencyInjection\TranslatorPass, which replaces the AbstractArgument with the array of loader ids.

this argument:

The issue here is not with SF >= 3.3, but rather 5.2 where the arguments are not resolved yet by the time this compiler pass runs

is opposite this argument:

I think the compiler pass can be updated to just rely on the new signature and does'n have to worry about the old signature

if the issue is the timing, then the order is correct. If the issue is the new signature order then timing doesn't matter.

What I meant with the new signature, is the one from Symfony 3.3, not 5.2. So if this bundle wanted to keep support for Symfony < 3.3, then either the compiler pass needs to be updated to run after the Symfony compiler pass, so that the arguments can be resolved before this pass runs, or this check can be changed to not merge the arrays. But this bundle dropped support for Symfony <= 3.3 in #271, so the pass needs to be updated to just check for the 4th index and doesn't have to cater for the 3rd index anymore.