Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271

vanputten · 2019-12-06T16:00:45Z

First contribution ever 👶

Fix Travis CI for 3.4|^4.0|^5.0
Add support for Symfony ^4.4 and ^5.0 to bundle
Drops support for php <5.6 (impossible to support 5.0 otherwise)
Drops support for Symfony <3.4 (impossible to support 5.0 otherwise)
(Backwards) compatible with Symfony ^3.4|^4.0|^5.0
Compatible with all major twig versions

Fixes #270
Fixes #258
Fixes #261
Fixes #264
FIxes #265
FIxes #269

composer.json

maxhelias · 2019-12-09T11:00:03Z

You also need to modify the travis.yml file to fit the new constraint of PHP & Symfony

….yml

vanputten · 2019-12-11T07:45:59Z

travis.yml has been updated to match the Symfony and PHP versions that this update should support
composer conflict on twig 1 and 2 has been hadden
support for symfony 4.1 has been restored

.travis.yml

composer.json

Controller/Controller.php

…0, but project_dir was only introduced in 3.3)

vanputten · 2019-12-11T10:50:10Z

PHP <5.6 was removed from travis since they no longer have support for it
Symfony <3.3 Support was dropped to allow Symfony 5.0 support (<3.3 is no longer maintained)

I did not see a way to maintain <3.3 support and at the same time add 5.0 support. kernel.root_dir has been removed since it has been replaced by kernel.project_dir since Symfony 3.3

vanputten · 2020-01-01T11:55:49Z

@maxhelias any chance you could review the latest version/my response to your comments? Would be nice if we can get this merged before too many other repos start relying on my fork.

maxhelias · 2020-01-06T08:25:29Z

@vanputten I did not have time to watch and try it. BTW, I'm not sure if it's a BC
@monteiro may have better vision than me.

monteiro · 2020-01-09T10:14:55Z

I will review this! Sorry for being out. My second son has just born.

maxhelias · 2020-01-09T10:17:31Z

Don't worry, I did a first review.
And congratulations 😃

vanputten · 2020-01-09T11:20:56Z

Congratulations @monteiro ! And awesome if you could review this! 🎉

kl3sk · 2020-01-09T16:34:04Z

Congrats 👏 @monteiro I wait for my second daughter ^^, but this bundle require your review

monteiro

I think everything looks fine.
There are some things specific to symfony 3.4 which probably will be cleaned after the deprecation in November 2020.

Any red flags?

Thanks a lot for the review and @vanputten for the PR.

monteiro · 2020-01-09T23:26:44Z

Controller/Controller.php

@@ -109,7 +119,7 @@ public function getTranslationsAction(Request $request, $domain, $_format)
        $locales = $this->getLocales($request);

        if (0 === count($locales)) {
-            throw new NotFoundHttpException();
+            return (new Response())->setStatusCode(Response::HTTP_NOT_FOUND);


For now I think it is ok. Symfony 3.4 will be a pain to support always so when it gets deprecated on November 2020 we can change this piece of code.

vanputten · 2020-01-10T07:32:59Z

Thanks for the approval @monteiro !

kl3sk · 2020-01-14T10:04:00Z

Is this PR will be merged ? Not installable yet on SF5 from packagist

vanputten · 2020-01-14T10:13:10Z

@kl3sk no, not merged yet. Only approved. Not sure who needs to do the merge and release

kl3sk · 2020-01-14T10:17:04Z

Bad news, @maxhelias and/or @monteiro are not able to do it ?

monteiro · 2020-01-14T11:00:54Z

I can merge. I will merge it today and create a release.

Controller/Controller.php

Tests/Fixtures/app/config/base_config.yml

composer.json

monteiro · 2020-01-14T16:26:04Z

@stof just applied all your suggestions. Thanks for the review.

…ter.utf8

Dumper/TranslationDumper.php

monteiro · 2020-01-14T16:51:36Z

Now yes! I think everything is done! 😄 let's wait for tests to go green.

Melvin added 7 commits December 6, 2019 16:09

Rename all Twig_Environment to Twig 3.0 namespacing

f935b51

Update composer to require Symfony 4.4

6d93524

Remove obsolete Use statement

939defb

TreeBuilder requires a name

3a62801

Alter node configuration to use new syntax

e7f398b

Add exception_controller option to get rid of Twig deprecation warning

d526100

Set composer fixed to 4.4.*

6934557

monteiro reviewed Dec 8, 2019

View reviewed changes

composer.json Outdated Show resolved Hide resolved

Melvin and others added 2 commits December 9, 2019 09:42

Change composer json versioning

cddffec

Merge branch 'master' into 4.4

87b0d0d

vanputten requested a review from monteiro December 9, 2019 10:01

vanputten changed the title ~~Add support for Symfony 4.4~~ Add support for Symfony ~4.4|~5.0 Dec 9, 2019

maxhelias reviewed Dec 9, 2019

View reviewed changes

composer.json Outdated Show resolved Hide resolved

Melvin added 6 commits December 9, 2019 13:43

Make composer compatible for symfony ^4.0 + add 4.4 and 5.0 to travis…

002ae95

….yml

Remove symfony 2 and 3 from travis

25c7d2f

Remove 5.* PHP versions from travis

8ae0e3d

Fix incompatible tearDown method

43ac603

Restore support for symfony 4.1

e145321

Restore support for symfony 4.1

9fe2bfd

maxhelias reviewed Dec 11, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

Controller/Controller.php Show resolved Hide resolved

Melvin added 5 commits December 11, 2019 11:25

Restore support for Symfony <4

5f00c5e

Readd symfony 3 and 2 to travis.yml

8005a1e

Drop php <5.6 from travis.yml since travis no longer supports these

eb27d83

Allow phpunit 6

82d4c4f

Drop symfony < 3.3 to allow 5.0 support (root_dir is deprecated in 5.…

2f76b4b

…0, but project_dir was only introduced in 3.3)

Melvin added 2 commits December 11, 2019 12:01

Fix broken paths due to project_dir

b2b4782

Add support for both legacy and 5.0 translator interface

df54a46

monteiro approved these changes Jan 9, 2020

View reviewed changes

maxhelias approved these changes Jan 10, 2020

View reviewed changes

stof suggested changes Jan 14, 2020

View reviewed changes

Controller/Controller.php Outdated Show resolved Hide resolved

Tests/Fixtures/app/config/base_config.yml Outdated Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

monteiro added 2 commits January 14, 2020 16:17

use NotFoundHttpException in special case for symfony < 4.4

1ec6eab

fix composer typo

8d7295a

monteiro added 2 commits January 14, 2020 16:32

remove deprecation message for symfony 5.1 related with framework.rou…

7faa3d5

…ter.utf8

remove deprecation warnings for symfony 5.1

76a22bf

maxhelias reviewed Jan 14, 2020

View reviewed changes

Dumper/TranslationDumper.php Outdated Show resolved Hide resolved

monteiro added 3 commits January 14, 2020 16:47

fix

0cde017

twig namespace fix

2ece4d8

fix spacing

d1fe77a

monteiro mentioned this pull request Jan 14, 2020

fix some unit tests and increase symfony versions #267

Closed

monteiro merged commit 1593975 into willdurand:master Jan 14, 2020

This was referenced Jan 15, 2020

Fix deprecation "A tree builder without a root node is deprecated sin… #260

Closed

Remove dependency on vanputten's fork for BazingaJS zikula/core#4067

Merged

This was referenced Oct 24, 2020

Remove support for Symfony < 3.3 constructor signature #294

Merged

Add support for Symfony 3.3 #201

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271

Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271

vanputten commented Dec 6, 2019 •

edited

Loading

maxhelias commented Dec 9, 2019

vanputten commented Dec 11, 2019

vanputten commented Dec 11, 2019 •

edited

Loading

vanputten commented Jan 1, 2020

maxhelias commented Jan 6, 2020 •

edited

Loading

monteiro commented Jan 9, 2020

maxhelias commented Jan 9, 2020

vanputten commented Jan 9, 2020

kl3sk commented Jan 9, 2020

monteiro left a comment •

edited

Loading

monteiro Jan 9, 2020

vanputten commented Jan 10, 2020

kl3sk commented Jan 14, 2020

vanputten commented Jan 14, 2020

kl3sk commented Jan 14, 2020

monteiro commented Jan 14, 2020

monteiro commented Jan 14, 2020

monteiro commented Jan 14, 2020 •

edited

Loading

Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271

Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271

Conversation

vanputten commented Dec 6, 2019 • edited Loading

maxhelias commented Dec 9, 2019

vanputten commented Dec 11, 2019

vanputten commented Dec 11, 2019 • edited Loading

vanputten commented Jan 1, 2020

maxhelias commented Jan 6, 2020 • edited Loading

monteiro commented Jan 9, 2020

maxhelias commented Jan 9, 2020

vanputten commented Jan 9, 2020

kl3sk commented Jan 9, 2020

monteiro left a comment • edited Loading

Choose a reason for hiding this comment

monteiro Jan 9, 2020

Choose a reason for hiding this comment

vanputten commented Jan 10, 2020

kl3sk commented Jan 14, 2020

vanputten commented Jan 14, 2020

kl3sk commented Jan 14, 2020

monteiro commented Jan 14, 2020

monteiro commented Jan 14, 2020

monteiro commented Jan 14, 2020 • edited Loading

vanputten commented Dec 6, 2019 •

edited

Loading

vanputten commented Dec 11, 2019 •

edited

Loading

maxhelias commented Jan 6, 2020 •

edited

Loading

monteiro left a comment •

edited

Loading

monteiro commented Jan 14, 2020 •

edited

Loading