-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271
Conversation
You also need to modify the travis.yml file to fit the new constraint of PHP & Symfony |
|
…0, but project_dir was only introduced in 3.3)
I did not see a way to maintain <3.3 support and at the same time add 5.0 support. |
@maxhelias any chance you could review the latest version/my response to your comments? Would be nice if we can get this merged before too many other repos start relying on my fork. |
@vanputten I did not have time to watch and try it. BTW, I'm not sure if it's a BC |
I will review this! Sorry for being out. My second son has just born. |
Don't worry, I did a first review. |
Congratulations @monteiro ! And awesome if you could review this! 🎉 |
Congrats 👏 @monteiro I wait for my second daughter ^^, but this bundle require your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks fine.
There are some things specific to symfony 3.4 which probably will be cleaned after the deprecation in November 2020.
Any red flags?
Thanks a lot for the review and @vanputten for the PR.
Controller/Controller.php
Outdated
@@ -109,7 +119,7 @@ public function getTranslationsAction(Request $request, $domain, $_format) | |||
$locales = $this->getLocales($request); | |||
|
|||
if (0 === count($locales)) { | |||
throw new NotFoundHttpException(); | |||
return (new Response())->setStatusCode(Response::HTTP_NOT_FOUND); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I think it is ok. Symfony 3.4 will be a pain to support always so when it gets deprecated on November 2020 we can change this piece of code.
Thanks for the approval @monteiro ! |
Is this PR will be merged ? Not installable yet on SF5 from packagist |
@kl3sk no, not merged yet. Only approved. Not sure who needs to do the merge and release |
Bad news, @maxhelias and/or @monteiro are not able to do it ? |
I can merge. I will merge it today and create a release. |
@stof just applied all your suggestions. Thanks for the review. |
Now yes! I think everything is done! 😄 let's wait for tests to go green. |
First contribution ever 👶
Fix Travis CI for 3.4|^4.0|^5.0
Add support for Symfony ^4.4 and ^5.0 to bundle
Drops support for php <5.6 (impossible to support 5.0 otherwise)
Drops support for Symfony <3.4 (impossible to support 5.0 otherwise)
(Backwards) compatible with Symfony ^3.4|^4.0|^5.0
Compatible with all major twig versions
Fixes #270
Fixes #258
Fixes #261
Fixes #264
FIxes #265
FIxes #269