Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271
Add support for Symfony ^4.0|^5.0 + fix various deprecations + fix travis CI #271
Changes from 32 commits
f935b51
6d93524
939defb
3a62801
e7f398b
d526100
6934557
cddffec
87b0d0d
002ae95
25c7d2f
8ae0e3d
43ac603
e145321
9fe2bfd
5f00c5e
8005a1e
eb27d83
82d4c4f
2f76b4b
b2b4782
df54a46
77d87b9
846f51e
75c239f
ad11a99
e6a7bbe
aac2513
fd975a6
a3338b6
a40d370
d795253
1ec6eab
8d7295a
7faa3d5
76a22bf
0cde017
2ece4d8
d1fe77a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted. What blocker do you have ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ControllerTest.php
testGetTranslationsWithPathTraversalAttack
andtestGetTranslationsWithLocaleInjection
expect a Response with status 404, but get a NotFoundException.This works fine in Symfony ^4.0 and ^5.0, but in Symfony 3.4 this fails (probably because the 3.4 exception handler does not turn it into a 404 Response object, whereas the 4.0 and 5.0 handlers do).
I thought it made more sense to return an actual 404 response, since according to the
ControllerTest
that is what we expect to get anyway (line 184 and 201 ofControllerTest.php
).I would say either return an actual 404 response
OR change the ControllerTest to test for an uncaught
NotFoundException
instead of 404 responseIf you want to reproduce the error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I think it is ok. Symfony 3.4 will be a pain to support always so when it gets deprecated on November 2020 we can change this piece of code.