fix some unit tests and increase symfony versions #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienHarper
approved these changes
Nov 12, 2019
maxhelias
reviewed
Nov 12, 2019
| - 5.6 | ||
| - 7.0 |
There was a problem hiding this comment.
PHP 7.0 is no longer maintained, I think we can remove it. ref #261
Before I approve, do you want to fix all the errors in this PR or fix only the memory-limit and retry all pending PRs ?
stof
reviewed
Nov 12, 2019
|
Close in favor of #271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you help reviewing the file
.travis.yml@stof ?The goal is to support the latest LTS, plus the latest versions so we unblock the latest PRs.
The memory problem only happens with PHP56: