Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures every ARIA progressbar node has an accessible name #82

Closed
1 task done
rkristelijn opened this issue Jul 12, 2021 · 2 comments
Closed
1 task done

Ensures every ARIA progressbar node has an accessible name #82

rkristelijn opened this issue Jul 12, 2021 · 2 comments

Comments

@rkristelijn
Copy link
Contributor

rkristelijn commented Jul 12, 2021 •
edited
Loading

I'm submitting a ... (check one with "x")

  • bug report => search github for a similar issue or PR before submitting

Current behavior

When running axe-core on the demo application of this repository, you will get the following errors:

Impact: serious
Issue Tags: cat.aria, wcag2a, wcag111
Issue Description: Ensures every ARIA progressbar node has an accessible name
Axe-core: 4.2.3

This is caused by missing aria-label on the <span> element.

Expected behavior

When running ngx skeleton loader I would expect no accessibility issues.

Reproduction of the problem

clone the repo, npm i, npm start, run the axe-core plugin.

image

What is the motivation / use case for changing the behavior?

Accessibility doesn't need a business case. An inaccessible app is a broken app.

Please tell us about your environment:

  • Browser: [all ]
  • Language: [all]
@rkristelijn
Copy link
Contributor Author

fixed in #83

willmendesneto pushed a commit that referenced this issue Jul 13, 2021
@rkristelijn
fix: adds aria-label for WCAG 2.1 AA #82 (#83)
7163715 
* fix: adds aria-label for WCAG 2.1 AA support

* docs: adds aria-label input

Co-authored-by: Remi Kristelijn <remi.kristelijn@theapsgroup.com>
@willmendesneto
Copy link
Owner

willmendesneto commented Jul 13, 2021 •
edited
Loading

Thanks @rkristelijn for the issue and the pull request ! Sharing some updates about this issue

The pull request got merged and all the validations pre publish are done. Please update your project to use ngx-skeleton-loader@2.10.1 to get this issue fixed and enjoy!

Closing this issue for now. Once again, thanks @rkristelijn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willmendesneto @rkristelijn