fix: adds aria-label for WCAG 2.1 AA #82 #83
Conversation
|
@willmendesneto can you have a look? |
There was a problem hiding this comment.
Thanks for raising that pull request @rkristelijn!
package-lock.json was changed by mistake here, so it should be reverted. Also, the checks on the pipeline are failing on CircleCI.
Besides that, looks good to me! I'll wait for the updates tomorrow. Otherwise, I can apply the changes and publish a new version of the package including the fix.
Once again, thanks mate!
| @@ -12,6 +12,7 @@ | |||
| "e2e": "ng e2e", | |||
| "bundlesize": "bundlesize", | |||
| "build:pkg": "ng build ngx-skeleton-loader --prod", | |||
| "build:pkg:trace": "node --trace-warnings ./node_modules/@angular/cli/bin/ng build ngx-skeleton-loader --prod", | |||
There was a problem hiding this comment.
No need for this command here. Since it's a relevant issue I'm removing myself to get the issue quickly published
|
Sharing some updates: The pull request got merged and all the validations pre publish are done. Please update your project to use |
Please check if the PR fulfills these requirements
guidelines
What kind of change does this PR introduce? (check one with "x")
If it is a Bugfix, please describe the root cause and what could have been done to prevent it…
What is the current behavior? (You can link to an open issue here, add screenshots…)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration
path for existing applications: …
Other information (if applicable):
Please @mention @people to review this PR…