-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): not to show 1 test when no tests are in the file #7205
fix(cli): not to show 1 test when no tests are in the file #7205
Conversation
Thanks for opening this pull request! 🎉
|
60d6a60
to
36fa8ae
Compare
@ChihweiLHBird thanks for this! Do you mind adding a few more details in the description on the bug itself and how this will look like after the fix? |
Hi @eladb, thanks for the suggestion! This is just a draft PR and I will mark it as ready after adding those things. Let me know if you have any feedback or anything, for example whether this is the right way to fix it, thanks! ^_^ |
af8c30e
to
7ad0c77
Compare
15ef261
to
2b27588
Compare
6e7d16e
to
1b3de89
Compare
@ChihweiLHBird let us know if you need any help |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@eladb Does it look good to you? Or any suggestion? |
Thanks for your contribution! I'm having a look at the CI problem here 👀 ... |
❌ Unstable Self-Mutation ❌Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
|
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Thanks for contributing, @ChihweiLHBird! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.85.32. |
This is to fix an issue that caused
wing test
against an emptysome_file_name.w
file showsTests 1 passed (1)
.See the issue #5852 for details.
Solution:
Instead of adding a dummy pass message, the function now returns early with a predefined message when there's no test case to avoid confusion later.
And I don't think it would need full E2E tests?
I am still exploring how to add test for this new test system behavior. Will mark the PR as ready after adding/updating test for it.
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.
Resolves #5852