-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colors not appearing in non-tty environments #751
Conversation
@@ -6,6 +6,9 @@ | |||
* | |||
*/ | |||
|
|||
// Fix colors not appearing in non-tty environments | |||
require('colors').enabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be require('colors/safe').enabled = true
to avoid String.prototype
modifications. Actually, adding it on line 13 with just colors.enabled = true
should be more than enough.
We want to try to add test coverage here before merging this. |
@indexzero can I help here? Would really like to get this merged in. |
@fiznool absolutely. Can you write a test that spins up a process running |
@indexzero I've added test coverage for this and rebased/squashed commits. |
Awesome work @fiznool! |
Fix colors not appearing in non-tty environments
Thanks for the speedy merge! |
I'll always make time for anyone who takes the extra time to write tests and contribute to keeping the quality of the project high. Again: well done. |
Fixes #609, #616, #669
Also maybe fixes #648?