Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump winston from 2.2.0-e to 2.2.0 in /electron #1346

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps winston from 2.2.0-e to 2.2.0.

Changelog

Sourced from winston's changelog.

v2.1.1 / 2015-11-18

COLOR ME IMPRESSED EDITION

  • #751, Fix colors not appearing in non-tty environments. Fixes #609, #616, #669, #648 (fiznool).
  • #752 Correct syslog RFC number. 5424 instead of 524. (jbenoit2011)

v2.1.0 / 2015-11-03

TEST ALL THE ECOSYSTEM EDITION

  • #742, 32d52b7 Distribute common test files used by transports in the winston ecosystem.

v2.0.1 / 2015-11-02

BUGS ALWAYS HAPPEN OK EDITION

  • #739, 1f16861 Ensure that logger.log("info", undefined) does not throw.

v2.0.0 / 2015-10-29

OMG IT'S MY SISTER'S BIRTHDAY EDITION

Breaking changes

Most important

  • 0f82204 Move winston.transports.DailyRotateFile into a separate module: require('winston-daily-rotate-file');
  • fb9eec0 Reverse log levels in npm and cli configs to conform to RFC524. Fixes #424 #406 #290
  • 8cd8368 Change the method signature to a filter function to be consistent with rewriter and log functions:
function filter (level, msg, meta, inst) {
  // Filter logic goes here...
}

Other breaking changes

  • e0c9dde Remove winston.transports.Webhook. Use winston.transports.Http instead.
  • f71e638 Remove Logger.prototype.addRewriter and Logger.prototype.addFilter since they just push to an Array of functions. Use logger.filters.push or logger.rewriters.push explicitly instead.
  • a470ab5 No longer respect the handleExceptions option to new winston.Logger. Instead just pass in the exceptionHandlers option itself.
  • 8cb7048 Removed Logger.prototype.extend functionality

New features

  • 3aa990c Added Logger.prototype.configure which now contains all logic previously in the winston.Logger constructor function. (indexzero)
  • #726 Update .npmignore (coreybutler)
  • #700 Add an eol option to the Console transport. (aquavitae)
  • #731 Update lib/transports.js for better static analysis. (indexzero)

Fixes, refactoring, and optimizations. OH MY!

  • #632 Allow File transport to be an objectMode writable stream. (stambata)
  • #527, 163f4f9, 3747ccf Performance optimizations and string interpolation edge cases (indexzero)
  • f0edafd Code cleanup for reability, ad-hoc styleguide enforcement (indexzero)

v1.1.1 - v1.1.2 / 2015-10

MINOR FIXES EDITION

... (truncated)

Commits

You can also trigger a rebase of this PR by commenting @dependabot rebase.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.

@@ -35,7 +35,7 @@
"request": "2.85.0",
"spellchecker": "3.4.4",
"uuid": "3.2.1",
"winston": "https://github.com/wireapp/winston.git#2.2.0-e"
"winston": "https://github.com/wireapp/winston.git#2.2.0"
Copy link
Contributor

@lipis lipis Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting: https://github.com/wireapp/winston/releases

Most likely I had to do 2.2.0e or something.. but I still think that 2.2.0-e > 2.2.0

/cc @dependabot

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's getting picked up as a pre-release version - docs here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we want to increase the version but without changing the 2.2.0 (because it comes from upstream and we just have a patch..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS doesn't have a way to do that 😢. In Python you'd use a + separator to specify a "local version identifier" for exactly that use case, but that's not available here.

I'd recommend just closing this PR and letting Dependabot update you when a new version comes out. I'd also like to add functionality for Dependabot to detect that you're using a fork and create PRs to move you to the main library if/when the commit you're pinned on on that fork is included in a release, but it's one for the future, not now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @greysteil! Sometimes you are faster than bots :)

@lipis lipis closed this Mar 19, 2018
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/electron/winston-2.2.0 branch March 19, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants