Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include legalhold request pending when observing self user legalhold state [WPB-6464] #2479

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Feb 8, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We had 2 separate use cases for the self user: to observe legal hold state (enabled/disabled) or legal hold request pending state (available / not), but the legal hold state for self user should be a combination of both and be one of three states: enabled / disabled / request pending.

Solutions

Change the use case for observing self user legal hold state to return the combined state including the pending request.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results

2 893 tests  +1   2 771 ✔️ +1   2m 51s ⏱️ +3s
   509 suites ±0      122 💤 ±0 
   509 files   ±0          0 ±0 

Results for commit afbb384. ± Comparison against base commit 807bd64.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
com.wire.kalium.logic.feature.legalhold.ObserveLegalHoldForSelfUserUseCaseTest ‑ givenLegalHoldObserverForUserReturnsDisabled_whenStartingObservingForSelfUser_thenEmitDisabled[jvm]
com.wire.kalium.logic.feature.legalhold.ObserveLegalHoldForSelfUserUseCaseTest ‑ givenLegalHoldObserverForUserReturnsEnabled_whenStartingObservingForSelfUser_thenEmitEnabled[jvm]
com.wire.kalium.logic.feature.legalhold.ObserveLegalHoldStateForSelfUserUseCaseTest ‑ givenLegalHoldDisabledAndNoRequestPending_whenStartingObservingForSelfUser_thenEmitDisabled[jvm]
com.wire.kalium.logic.feature.legalhold.ObserveLegalHoldStateForSelfUserUseCaseTest ‑ givenLegalHoldEnabled_whenStartingObservingForSelfUser_thenEmitEnabled[jvm]
com.wire.kalium.logic.feature.legalhold.ObserveLegalHoldStateForSelfUserUseCaseTest ‑ givenLegalHoldRequestAvailable_whenStartingObservingForSelfUser_thenEmitRequestPending[jvm]

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

All test runs 9337692 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2037 37 16.27s Link
kalium-jvm 0 0 0 2771 122 8m 42s Link

@saleniuk saleniuk added this pull request to the merge queue Feb 8, 2024
Merged via the queue into develop with commit 65f9293 Feb 8, 2024
17 checks passed
@saleniuk saleniuk deleted the feat/include-legalhold-request-when-observing-self-legalhold-state branch February 8, 2024 14:31
augustocdias pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants