feat: legal hold - update banners to v2 [WPB-6464]

[saleniuk]

WPB-6464 [Android] Update banners to v2 according to designs

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Designs for legal hold banners on “home” screen got updated, currently V2 is only available, so the app needs to be updated according to the recent designs.

Solutions

Removed top bar legal hold banner which was visible on all logged in screens right below the call or connection banner.
Instead, added a border around the avatar which indicates that the user is under legal hold or has pending request.
The dialog to approve it is available on the self user profile screen by clicking on “approve” on the legal hold pending banner.
Used updated use case for observing self user legal hold state that includes legal hold pending request.

Dependencies (Optional)

Needs releases with:

• feat: include legalhold request pending when observing self user legalhold state [WPB-6464] kalium#2479

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Enable legal hold or request it for the user.

Attachments (Optional)

Before	After

legal_hold_v2.mp4

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

816 tests  ±0   816 ✅ ±0   15m 0s ⏱️ + 2m 44s
114 suites +1     0 💤 ±0 
114 files   +1     0 ❌ ±0 

Results for commit 91ef870. ± Comparison against base commit ecb7ff1.

This pull request removes 5 and adds 5 tests. Note that renamed tests count towards both.

com.wire.android.ui.common.topappbar.CommonTopAppBarViewModelTest ‑ givenLegalHoldRequestAndAuthRelatedScreen_whenGettingState_thenShouldNotHaveLegalHoldRequestInfo()
com.wire.android.ui.common.topappbar.CommonTopAppBarViewModelTest ‑ givenLegalHoldRequestAndCallScreen_whenGettingState_thenShouldNotHaveLegalHoldRequestInfo()
com.wire.android.ui.common.topappbar.CommonTopAppBarViewModelTest ‑ givenLegalHoldRequestAndHomeScreen_whenGettingState_thenShouldHaveLegalHoldRequestInfo()
com.wire.android.ui.common.topappbar.CommonTopAppBarViewModelTest ‑ givenNoLegalHoldRequest_whenGettingState_thenShouldNotHaveLegalHoldRequestInfo()
com.wire.android.ui.userprofile.self.SelfUserProfileViewModelTest ‑ given legal hold request available, then isUnderLegalHold is pending()

com.wire.android.ui.home.HomeViewModelTest ‑ given legal hold disabled and no request available, then shouldDisplayLegalHoldIndicator is false()
com.wire.android.ui.home.HomeViewModelTest ‑ given legal hold enabled, then shouldDisplayLegalHoldIndicator is true()
com.wire.android.ui.home.HomeViewModelTest ‑ given legal hold enabled, when user status changes, then shouldDisplayLegalHoldIndicator should keep the same()
com.wire.android.ui.home.HomeViewModelTest ‑ given legal hold request pending, then shouldDisplayLegalHoldIndicator is true()
com.wire.android.ui.userprofile.self.SelfUserProfileViewModelTest ‑ given legal hold request pending, then isUnderLegalHold is pending()

♻️ This comment has been updated with latest results.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 2937 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.0(8827346)(8827346)-staging-compat.apk

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ecb7ff1) 42.86% compared to head (91ef870) 43.01%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2668      +/-   ##
===========================================
+ Coverage    42.86%   43.01%   +0.14%     
===========================================
  Files          405      405              
  Lines        13463    13465       +2     
  Branches      2376     2376              
===========================================
+ Hits          5771     5792      +21     
+ Misses        7013     6993      -20     
- Partials       679      680       +1     

Files	Coverage Δ
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt	0.00% <ø> (ø)
.../main/kotlin/com/wire/android/ui/home/HomeState.kt	33.33% <100.00%> (+33.33%)	⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt	51.49% <100.00%> (-1.07%)	⬇️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt	54.28% <87.50%> (+54.28%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb7ff1...91ef870. Read the comment docs.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 2988 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.0(8843274)(8843274)-staging-compat.apk

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 2992 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.0(8843683)(8843683)-staging-compat.apk