Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: original image path was used images from share extension #2626

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app crash when sharing high-res images from the sharing extension

Causes (Optional)

the image is rescaled but the original path is used to send the image

Solutions

use the scalded image path to send

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested review from a team, typfel, alexandreferris, borichellow, vitorhugods and mchenani and removed request for a team January 25, 2024 11:14
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (2a61529) 41.22% compared to head (90a2df8) 41.50%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2626      +/-   ##
=============================================
+ Coverage      41.22%   41.50%   +0.27%     
- Complexity      1140     1151      +11     
=============================================
  Files            367      368       +1     
  Lines          13272    13268       -4     
  Branches        1752     1748       -4     
=============================================
+ Hits            5472     5507      +35     
+ Misses          7273     7234      -39     
  Partials         527      527              
Files Coverage Δ
...c/main/kotlin/com/wire/android/model/ImageAsset.kt 88.46% <100.00%> (ø)
...essagecomposer/location/LocationPickerViewModel.kt 80.00% <100.00%> (+80.00%) ⬆️
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <ø> (ø)
...com/wire/android/util/ui/WireSessionImageLoader.kt 10.16% <ø> (+0.16%) ⬆️
...tlin/com/wire/android/util/ui/AssetImageFetcher.kt 69.38% <0.00%> (+7.98%) ⬆️
.../com/wire/android/ui/sharing/ImportedMediaTypes.kt 0.00% <0.00%> (ø)
...e/messagecomposer/location/LocationPickerHelper.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7bbef...90a2df8. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results

752 tests   752 ✅  7m 49s ⏱️
106 suites    0 💤
106 files      0 ❌

Results for commit 90a2df8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina changed the title fix: original image path was used images when sharing from share exte… fix: original image path was used images from share extension Jan 25, 2024
@AndroidBob
Copy link
Collaborator

Build 2750 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 26, 2024
Merged via the queue into develop with commit 652898a Jan 26, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the fix/original-images-was-sent-when-sending-form-external branch January 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants