-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: original image path was used images from share extension #2626
fix: original image path was used images from share extension #2626
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
=============================================
+ Coverage 41.22% 41.50% +0.27%
- Complexity 1140 1151 +11
=============================================
Files 367 368 +1
Lines 13272 13268 -4
Branches 1752 1748 -4
=============================================
+ Hits 5472 5507 +35
+ Misses 7273 7234 -39
Partials 527 527
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test Results752 tests 752 ✅ 7m 49s ⏱️ Results for commit 90a2df8. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 2750 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
app crash when sharing high-res images from the sharing extension
Causes (Optional)
the image is rescaled but the original path is used to send the image
Solutions
use the scalded image path to send
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.