fix: Use idp client id from remote (WPB-6494) #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
yamilmedina,
borichellow,
MohamadJaara and
vitorhugods
and removed request for
a team
Test Results802 tests 802 ✅ 11m 51s ⏱️ Results for commit 623419a. ♻️ This comment has been updated with latest results. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3050 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Feb 12, 2024
app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt
Outdated
Show resolved
Hide resolved
vitorhugods
reviewed
Feb 13, 2024
|
Build 3076 failed. |
|
Build 3086 failed. |
|
Build 3098 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3100 succeeded. The build produced the following APK's: |
mchenani
approved these changes
Feb 13, 2024
app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt
Outdated
Show resolved
Hide resolved
…to Use_IDP_clientId_from_remote
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3108 succeeded. The build produced the following APK's: |
|
APKs built during tests are available here. Scroll down to Artifacts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
ClientID is hardcoded
Solutions
Get client id from url and remove client secret
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.