Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use idp client id from remote (WPB-6494) #2703

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 13, 2024

BugWPB-6494 [Android] Use IDP clientId from remote

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

ClientID is hardcoded

Solutions

Get client id from url and remove client secret

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d2559d6) 42.83% compared to head (9912c2e) 42.99%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2703      +/-   ##
===========================================
+ Coverage    42.83%   42.99%   +0.16%     
===========================================
  Files          408      408              
  Lines        13516    13520       +4     
  Branches      2389     2393       +4     
===========================================
+ Hits          5789     5813      +24     
+ Misses        7051     7022      -29     
- Partials       676      685       +9     
Files Coverage Δ
...p/src/main/kotlin/com/wire/android/util/UriUtil.kt 81.25% <80.00%> (-0.57%) ⬇️
...tlin/com/wire/android/feature/e2ei/OAuthUseCase.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2559d6...9912c2e. Read the comment docs.

Copy link
Contributor

Test Results

819 tests  +3   819 ✅ +3   9m 45s ⏱️ -52s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit 9912c2e. ± Comparison against base commit d2559d6.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3119 succeeded.

The build produced the following APK's:

@ohassine ohassine requested review from a team, typfel, alexandreferris, vitorhugods, Garzas and saleniuk and removed request for a team February 14, 2024 08:05
@ohassine ohassine added this pull request to the merge queue Feb 14, 2024
Merged via the queue into develop with commit da94699 Feb 14, 2024
15 checks passed
@ohassine ohassine deleted the Use_IDP_clientId_from_remote-cherry-pick branch February 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants