fix: MLS degraded dialogs [WPB-6607] #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2715 +/- ##
===========================================
- Coverage 43.01% 42.90% -0.11%
===========================================
Files 408 408
Lines 13527 13524 -3
Branches 2393 2391 -2
===========================================
- Hits 5818 5803 -15
- Misses 7024 7044 +20
+ Partials 685 677 -8
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3165 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Feb 16, 2024
borichellow
approved these changes
Feb 19, 2024
|
Build 3211 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3213 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
need this PR be merge first wireapp/kalium#2502
What's new in this PR?
Issues
When a conversation becomes degraded, we must show a message to the user when:
Expected:
they try to send a message
they try to start a call
stop the ongoing call
Actual: None of the above happen!
Causes (Optional)
Was not implemented on kalium side + this dialog should be shown every time user sends a message AND didn't click Send anywhere yet
Solutions
Update kalium + improve dialog dismiss logic
Waiting for update kalium
wireapp/kalium#2502