fix: Show alert message after conversation becomes degraded [WPB-6607] #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
cherry-pick
MohamadJaara
changed the title
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
borichellow
approved these changes
Feb 16, 2024
Garzas
approved these changes
Feb 16, 2024
…-becomes-degraded-rc-cherry-pick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2502 +/- ##
==========================================
Coverage 58.38% 58.38%
Complexity 21 21
==========================================
Files 1172 1172
Lines 45335 45336 +1
Branches 4288 4289 +1
==========================================
+ Hits 26468 26470 +2
Misses 16943 16943
+ Partials 1924 1923 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
borichellow
deleted the
fix/show-alert-message-after-conversation-becomes-degraded-rc-cherry-pick
branch
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
#2502) Co-authored-by: boris <boris.safonov@appunite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
What's new in this PR?
Issues
When a conversation becomes degraded, we must show a message to the user when:
Expected:
Actual: None of the above happen!
Causes (Optional)
Dialog showing flag was not updated on MLS status changes
Solutions
Update dialog showing flag on MLS status changes