fix: Show alert message after conversation becomes degraded RC [WPB-6607] #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
typfel,
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
…nversation-becomes-degraded-rc
mchenani
approved these changes
Feb 15, 2024
alexandreferris
approved these changes
Feb 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2501 +/- ##
====================================================
Coverage ? 58.39%
Complexity ? 21
====================================================
Files ? 1171
Lines ? 45306
Branches ? 4287
====================================================
Hits ? 26455
Misses ? 16928
Partials ? 1923 Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
borichellow
deleted the
fix/show-alert-message-after-conversation-becomes-degraded-rc
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
#2502) Co-authored-by: boris <boris.safonov@appunite.com>
jschumacher-wire
pushed a commit
that referenced
this pull request
Mar 6, 2024
#2502) Co-authored-by: boris <boris.safonov@appunite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When a conversation becomes degraded, we must show a message to the user when:
Expected:
Actual: None of the above happen!
Causes (Optional)
Dialog showing flag was not updated on MLS status changes
Solutions
Update dialog showing flag on MLS status changes