fix: crash when checking audio file size limit (WPB-5961)

[ohassine]

WPB-5961 [Android] Compose TapGestureDetectorKt crash

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

App is crashing sometimes when checking audio file size when recording voice.

Causes (Optional)

We were trying to use assetLimitInMegabyte before it get initialized

Property assetLimitInMegabyte should be initialized before get.

Solutions

Pass the audio size limit as function param when we setup audioMediaRecorder .

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

827 tests  ±0   827 ✅ ±0   12m 53s ⏱️ + 3m 40s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit 998bae0. ± Comparison against base commit 84d3737.

♻️ This comment has been updated with latest results.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[alexandreferris]

good catch 🎯

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.22%. Comparing base (84d3737) to head (998bae0).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2757      +/-   ##
===========================================
+ Coverage    42.98%   43.22%   +0.24%     
===========================================
  Files          409      409              
  Lines        13586    13584       -2     
  Branches      2397     2398       +1     
===========================================
+ Hits          5840     5872      +32     
+ Misses        7067     7025      -42     
- Partials       679      687       +8     

Files	Coverage Δ
...essagecomposer/recordaudio/RecordAudioViewModel.kt	70.87% <100.00%> (+0.87%)	⬆️
.../messagecomposer/recordaudio/AudioMediaRecorder.kt	0.00% <0.00%> (-2.05%)	⬇️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d3737...998bae0. Read the comment docs.

[AndroidBob]

Build 3438 failed.

[AndroidBob]

Build 3440 failed.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!