Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when checking audio file size limit (WPB-5961) (#2757) #2852

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Apr 4, 2024

BugWPB-5961 [Android] Compose TapGestureDetectorKt crash

(cherry picked from commit c8e59af)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

App is crashing sometimes when checking audio file size when recording voice.

Causes (Optional)

We were trying to use assetLimitInMegabyte before it get initialized

Property assetLimitInMegabyte should be initialized before get.

Solutions

Pass the audio size limit as function param when we setup audioMediaRecorder .

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Test Results

816 tests   816 ✅  12m 53s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit af50b19.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3957 failed.

@MohamadJaara MohamadJaara enabled auto-merge (squash) April 4, 2024 11:52
@MohamadJaara MohamadJaara merged commit ac7786b into release/candidate Apr 4, 2024
10 of 11 checks passed
@MohamadJaara MohamadJaara deleted the fix-crash-when-checking-audio-file-size-limit-RC branch April 4, 2024 12:10
Copy link
Contributor

github-actions bot commented Apr 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3963 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants