-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when checking audio file size limit (WPB-5961) (#2757) #2852
Merged
MohamadJaara
merged 5 commits into
release/candidate
from
fix-crash-when-checking-audio-file-size-limit-RC
Apr 4, 2024
Merged
fix: crash when checking audio file size limit (WPB-5961) (#2757) #2852
MohamadJaara
merged 5 commits into
release/candidate
from
fix-crash-when-checking-audio-file-size-limit-RC
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c8e59af)
ohassine
approved these changes
Apr 4, 2024
vitorhugods
approved these changes
Apr 4, 2024
Test Results816 tests 816 ✅ 12m 53s ⏱️ Results for commit af50b19. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
(cherry picked from commit 8b0809e)
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3957 failed. |
…h-when-checking-audio-file-size-limit-RC
MohamadJaara
deleted the
fix-crash-when-checking-audio-file-size-limit-RC
branch
April 4, 2024 12:10
8 tasks
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3963 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c8e59af)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
App is crashing sometimes when checking audio file size when recording voice.
Causes (Optional)
We were trying to use
assetLimitInMegabyte
before it get initializedSolutions
Pass the audio size limit as function param when we setup
audioMediaRecorder
.Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.