fix: RevokedCertificate dialog undismissable RC [WPB-7226] #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3984 succeeded. The build produced the following APK's: |
|
Was done by separate PR |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3999 succeeded. The build produced the following APK's: |
MohamadJaara
added a commit
that referenced
this pull request
Jul 8, 2024
MohamadJaara
added a commit
that referenced
this pull request
Jul 8, 2024
yamilmedina
deleted the
fix/revoked-certificate-dialog-undismissable-rc-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
kalium
What's new in this PR?
Issues
When the user has a revoked certificate, the dialogue informing the user about this can be dismissed by tapping somewhere on the screen. But it should not not be dismissible so that the user has to use one of the buttons.
Causes (Optional)
dismissable flags were missed in dialog
Solutions
add dismissable flags into that dialog