Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) #3157

Merged
merged 10 commits into from
Jul 8, 2024
Merged

fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) #3157

merged 10 commits into from
Jul 8, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 3, 2024 •
edited by github-actions bot
Loading

TaskWPB-9947 [Android] Implement asset sending restriction

Co-authored-by: yamilmedina yamilmedina@users.noreply.github.com

(cherry picked from commit 85d5a1e)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

asset restriction when sending, was not implemented

Solutions

show a snack bar error messag when sending a restricted file

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara
fix: asset restriction [WPB-9947] (#3114) (#3147)
af160c3 
Signed-off-by: MohamadJaara <mohamad.jaara@wire.com>

(cherry picked from commit 1a35424)
@MohamadJaara
asset restriction
244dedf
@MohamadJaara
chore: update kalium
4e5df65
@MohamadJaara MohamadJaara changed the title fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Test Results

945 tests   945 ✅  13m 42s ⏱️
126 suites    0 💤
126 files      0 ❌

Results for commit c500367.

♻️ This comment has been updated with latest results.

@MohamadJaara
Copy link
Member Author

hmmm I see that some tests got deleted during the cherry-pick, I will look at them tomorrow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

mchenani
mchenani approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some comments and questions.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 8, 2024 10:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MohamadJaara MohamadJaara merged commit 3213876 into release/candidate Jul 8, 2024
11 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/asset-restriction-rc branch July 8, 2024 11:18
MohamadJaara added a commit that referenced this pull request Jul 8, 2024
@MohamadJaara
fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) (#3157)
a666930 
(cherry picked from commit 3213876)
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2024
@MohamadJaara
fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) (#3157) (#3170
bce97f8 
)
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@saleniuk saleniuk Awaiting requested review from saleniuk

Assignees

@MohamadJaara MohamadJaara

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamadJaara @vitorhugods @mchenani