feat: Keyboard shortcuts (WEBAPP-4209) #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffflorian
previously requested changes
Oct 17, 2017
| @@ -24,7 +24,7 @@ const fs = require('fs-extra'); | |||
| const minimist = require('minimist'); | |||
| const path = require('path'); | |||
| const raygun = require('raygun'); | |||
| const {app, BrowserWindow, ipcMain, Menu, shell} = require('electron'); | |||
| const { app, BrowserWindow, globalShortcut, ipcMain, Menu, shell } = require('electron'); | |||
There was a problem hiding this comment.
At some point we decided to remove the spaces within { and }.
| webviewTag: true, | ||
| }, | ||
| webviewTag: true | ||
| } |
There was a problem hiding this comment.
We also decided to keep trailing commas ;)
There was a problem hiding this comment.
@ffflorian Absolutely right. But it is not in this projects eslint config. We have a discussion on how we are going to move forward with codestyle in general at wireapp/wire-webapp#1729 that you are more than welcome to share your opinions in. For now I will go ahead and merge it in order to prepare our release.
gregor
approved these changes
Oct 17, 2017
gregor
dismissed
ffflorian’s stale review
Dismissing after comment and f2f explanation.
|
Addresses #883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.