-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Prettier #1729
style: Prettier #1729
Conversation
Someone wants to become contributor nr. 1? 😛 |
To become #1 I need to push 800 different commits.. 🗡 :D |
and I'm still going to be second :P |
Vote here |
But it won't be flagged any longer. If you add a max line lenght in |
We are talking for something that we have it disable actually: https://eslint.org/docs/rules/max-len |
Yes, it is disabled since it was also creating too much noise in the past. We are not discussing the current state but how we can move forward with the tools to server our needs. |
* 'prettier' of github.com:wireapp/wire-webapp:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do yarn fix:config
(instead of fix:json
) to be consistent with fix:script
and fix:style
.
@bennyn updated |
Prettier
Read more about it here: https://github.com/prettier/prettier
Key changes
package.json
- new commands and pre-commit hooks should be much faster now.eslintrc.yaml
- for*.js
files.prettierrc.yaml
- for*.json
,*.less
New/modified commands:
yarn fix
Fixes all the possible file extensions that we support (js, json, less)
yarn fix:script
Fixes all the script files (js)
yarn fix:config
Fixes all the config files (json)
yarn fix:style
Fixes all the styke files (less)
yarn test
Executes all the tests
yarn test:script
Tests if the scripts are fine, but not modifying them