Skip to content

Commit

Permalink
fix add bots to conversations (#4424, #4425, #4426)
Browse files Browse the repository at this point in the history
Seperate the handling of
- /bot/conversation and
- /bot/conversation/.+ .

For /bot/conversation/.+
- redirect to and authenticate for brig.

For /bot/conversation
- leave redirected to and authenticated for galley.
  • Loading branch information
stefanwire authored and fisx committed Jan 28, 2025
1 parent 6da6945 commit 9e9629f
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# [2025-01-28] (Chart Release 5.10.0)

## Release notes


This is a hotfix release to re-enable adding and removing bots to conversations. (#4424, #4425, #4426)


# [2024-12-30] (Chart Release 5.9.0)

## Release notes
Expand Down
14 changes: 12 additions & 2 deletions charts/nginz/static/conf/zauth.acl
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
a (blacklist (regex "(/v[0-9]+)?/provider(/.*)?")
(regex "(/v[0-9]+)?/bot(/.*)?")
(regex "(/v[0-9]+)?/bot/self")
(regex "(/v[0-9]+)?/bot/client(/.*)?")
(regex "(/v[0-9]+)?/bot/users(/.*)?")
(regex "(/v[0-9]+)?/bot/assets(/.*)?")
(regex "(/v[0-9]+)?/bot/conversation$")
(regex "(/v[0-9]+)?/bot/messages")
(regex "(/v[0-9]+)?/i/.*"))

b (whitelist (regex "(/v[0-9]+)?/bot(/.*)?"))
b (whitelist (regex "(/v[0-9]+)?/bot/self")
(regex "(/v[0-9]+)?/bot/client(/.*)?")
(regex "(/v[0-9]+)?/bot/users(/.*)?")
(regex "(/v[0-9]+)?/bot/assets(/.*)?")
(regex "(/v[0-9]+)?/bot/conversation$")
(regex "(/v[0-9]+)?/bot/messages"))

p (whitelist (regex "(/v[0-9]+)?/provider(/.*)?"))

Expand Down
5 changes: 4 additions & 1 deletion charts/nginz/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,9 @@ nginx_conf:
- path: /upgrade-personal-to-team$
envs:
- all
- path: /bot/conversations/(.+)
envs:
- all
galley:
- path: /conversations/code-check
disable_zauth: true
Expand Down Expand Up @@ -503,7 +506,7 @@ nginx_conf:
- all
max_body_size: 40m
body_buffer_size: 256k
- path: /bot/conversation
- path: /bot/conversation$
envs:
- all
- path: /bot/messages
Expand Down

0 comments on commit 9e9629f

Please sign in to comment.