Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-15723 Fix Bot ACL config #4426

Merged
merged 2 commits into from
Jan 28, 2025
Merged

WPB-15723 Fix Bot ACL config #4426

merged 2 commits into from
Jan 28, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jan 28, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... label Jan 28, 2025
@battermann battermann requested a review from mastaab January 28, 2025 13:31
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 28, 2025
@battermann battermann marked this pull request as ready for review January 28, 2025 13:39
@battermann battermann merged commit 3bfc2a7 into develop Jan 28, 2025
11 checks passed
@battermann battermann deleted the wpb-15723-fix-bot-acl-config branch January 28, 2025 14:17
fisx pushed a commit that referenced this pull request Jan 28, 2025
@stefanwire @fisx
fix add bots to conversations (#4424, #4425, #4426)
9e9629f 
Seperate the handling of
- /bot/conversation and
- /bot/conversation/.+ .

For /bot/conversation/.+
- redirect to and authenticate for brig.

For /bot/conversation
- leave redirected to and authenticated for galley.
@fisx fisx mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastaab mastaab mastaab approved these changes

Assignees
No one assigned
Labels
echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @mastaab @zebot