Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: spar integration tests misconfigured on CI #1343

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

smatting
Copy link
Contributor

No description provided.

Control.Exception.assert (timeoutSecs < 30) $ do
threadDelay $ (timeoutSecs + 2) * 1_000_000
threadDelay $ (timeoutSecs + 1) * 1_000_000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted +2 seconds from #1333 back, because it was working fine with +1 before.

@smatting smatting changed the title Fix: spar integration test misconfigured on CI Fix: spar integration tests misconfigured on CI Jan 27, 2021
@jschaul jschaul mentioned this pull request Jan 27, 2021
@jschaul jschaul force-pushed the smatting/2021-01-27-spar-integration branch from 9991ee0 to 42d4e82 Compare January 27, 2021 19:05
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (CI also passed here!)! I rebased & force-pushed this branch to latest develop as there was a merge conflict with another PR I just merged.

@smatting smatting merged commit 7a3d7b4 into develop Jan 28, 2021
@smatting smatting deleted the smatting/2021-01-27-spar-integration branch January 28, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants