Brig integration tests #1342
Merged
Brig integration tests #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaymankar
approved these changes
Jan 27, 2021
smatting
approved these changes
Jan 27, 2021
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose: * refactor some brig-integration setup code (remove looking at environment variables) * brig now knows about federator's existence in the config file. This is an optional field. (should it be required?) * introduce a first test that needs two backends. This test is failing on this branch (but working to success on #1319 currently), but will be disabled-by-default to run both on CI and locally, as long as this PR is merged *after* #1341
jschaul
force-pushed
the
brig-integration-tests
branch
from
46f334b to
d81d9a1
Compare
|
Thanks for the review. Just waiting on CI to make sure it passes before merging. |
|
CI integration test failure (only in spar integration tests) will be fixed with #1343. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brig integration/end2end initial test for federation
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose:
variables)
an optional field. (should it be required?)
on this branch (but working to success on Use mu-haskell to implement one initial federation request across backends #1319 currently), but will
be disabled-by-default to run both on CI and locally, as long as this PR
is merged after Federation end2end test scripts and Makefile targets #1341
federatorandfederatorInternalconfig here: the former can be deleted as soon as some PRs involving the actual federator have made their way in, but it's kept in here to keep CI happy for the time being.