Federation end2end test scripts and Makefile targets #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose: * introduces telepresence as a new development dependency (right now only for running end2end federation tests spanning multiple backends) * prepares using brig as a place to keep some federation end2end tests spanning more than one backend, by using pattern matching on `brig-federation`: those tests will not run by default locally or on CI, until they are more stable and CI can actually run them. * Makefile targets and bash scripts to spawn up two backends (one backend will have a namespace-suffix-by-convention) and run a telepresence-based integration test. * Each ephemeral backend will have a unique federationDomain (based on the kubernetes namespace), so that tests spanning multiple backends become possible.
jschaul
added a commit
that referenced
this pull request
Jan 26, 2021
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose: * refactor some brig-integration setup code (remove looking at environment variables) * brig now knows about federator's existence in the config file. This is an optional field. (should it be required?) * introduce a first test that needs two backends. This test is failing on this branch (but working to success on #1319 currently), but will be disabled-by-default to run both on CI and locally, as long as this PR is merged *after* #1341
Merged
akshaymankar
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Looks good, this PR ideally should've just been merged with #1342 some assumptions here are only programmed there.
smatting
approved these changes
Jan 27, 2021
jschaul
added a commit
that referenced
this pull request
Jan 27, 2021
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose: * refactor some brig-integration setup code (remove looking at environment variables) * brig now knows about federator's existence in the config file. This is an optional field. (should it be required?) * introduce a first test that needs two backends. This test is failing on this branch (but working to success on #1319 currently), but will be disabled-by-default to run both on CI and locally, as long as this PR is merged *after* #1341
jschaul
added a commit
that referenced
this pull request
Jan 27, 2021
* Brig integration/end2end initial test for federation For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose: * refactor some brig-integration setup code (remove looking at environment variables) * brig now knows about federator's existence in the config file. This is an optional field. (should it be required?) * introduce a first test that needs two backends. This test is failing on this branch (but working to success on #1319 currently), but will be disabled-by-default to run both on CI and locally, as long as this PR is merged *after* #1341 * log pods and maybe errors when something (helm upgrade) fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier review, this PR is a small piece from the now-long-running "federation" branch #1319 with the following purpose:
brig-federation: those tests will not run by default locally or on CI, until they are more stable and CI can actually run them.(if you want to try this out for real, the following can be run: