Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port instances to schemas library #1482

Merged
merged 9 commits into from
May 12, 2021
Merged

Port instances to schemas library #1482

merged 9 commits into from
May 12, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented May 4, 2021 •
edited
Loading

This is work in progress to port some of the existing JSON and Swagger.ToSchema instances to the schemas library.

TODO

@pcapriotti pcapriotti marked this pull request as draft May 4, 2021 07:22
@pcapriotti pcapriotti marked this pull request as ready for review May 7, 2021 09:58
@pcapriotti pcapriotti mentioned this pull request May 10, 2021
Merged
@pcapriotti pcapriotti changed the title [WIP] Port instances to schemas library Port instances to schemas library May 11, 2021
@pcapriotti pcapriotti force-pushed the pcapriotti/typed-schema-v2-port branch from b5bdc58 to b2ed44e Compare May 11, 2021 13:57
@pcapriotti pcapriotti requested a review from akshaymankar May 11, 2021 14:01
akshaymankar
akshaymankar requested changes May 12, 2021
View reviewed changes
libs/types-common/src/Data/Handle.hs Outdated Show resolved Hide resolved
libs/types-common/src/Data/Id.hs Outdated Show resolved Hide resolved
libs/types-common/src/Data/Id.hs Outdated Show resolved Hide resolved
libs/types-common/src/Data/Id.hs Show resolved Hide resolved
libs/types-common/src/Data/Json/Util.hs Outdated Show resolved Hide resolved
libs/types-common/src/Data/Qualified.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Provider/Service.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Provider/Service.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Provider/Service.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/User/Identity.hs Outdated Show resolved Hide resolved
@pcapriotti pcapriotti requested a review from akshaymankar May 12, 2021 11:39
akshaymankar
akshaymankar approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jschaul jschaul mentioned this pull request May 12, 2021
Merged
@jschaul jschaul merged commit 66d6b44 into develop May 12, 2021
@jschaul jschaul deleted the pcapriotti/typed-schema-v2-port branch May 12, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @akshaymankar @jschaul