-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema migration for new tables #1485
Conversation
ab29660
to
f44cee9
Compare
…Conversation representation
…e associated authorization business and return events: that should be done in a followup PR instead
7a24bb9
to
c9ffc15
Compare
…, make the public one temporarily internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have taken the liberty to merge develop, and then remove JSON instances that were covered by schemas.
Looks good to me. I've added a few minor inline comments.
-- FUTUREWORK: Make a PR to the servant-swagger package with this instance | ||
instance ToSchema Servant.NoContent where | ||
declareNamedSchema _ = declareNamedSchema (Proxy @()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not normally necessary, because servant-swagger has a more specific instance for Verb ... NoContent
. Here we need it because NoContent
is inside UVerb
, but I'm not sure this is the best way.
I think this is fine for now, but for the purposes of submitting a PR, I think the proper way to support NoContent
in UVerb
is to have some more specific instances for ToSwagger
that do not necessarily require ToSchema
. I have done something similar for HasServer
and HasClient
in my servant PR.
/i/
prefix.OtherMember
to also give back a qualified user Id; this means that querying for a conversation (get /conversations/:cnv
) supports showing remote users. For this, golden tests had to be adjusted, which accounts for some of the noise of this PR.See the comment in https://github.com/wireapp/wire-server/pull/1485/files#diff-259be1b8909f30421ab02e60765d6e90ae68426b95c3aa8303c57945dc84dd37R467-R481 for some next steps that can be implemented once this PR is merged.